Github workflow changes#720
Merged
Merged
Conversation
- for the --version option, the script should not end with exitcode 1 even if it was successful -- changed from exit 1 to exit $?
- implement sensitivity to debug options to .github/action/build-docker - fix the availability of python for quicktest - merge the deployment of the docs into the build job (so deployment is not its own job and logs are more "together")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main issue here was that
run_fastsurfer.sh --versionexited with error code 1, which meant the build action terminated with no image built. This is now fixed.The issue here was that in PRs we always had 2 of 3 checks successful, which was misleading. This could be traced back to deploy being a job that was started, but then skipped. Now, deploy is part of the build job, but only executed on the push trigger and not the pull_request trigger. In effect the outcome is the same, but a "skipped check" is no longer created.
Testing of FastSurfer-doc
Testing of FastSurfer-quicktest