Fix quicktest outputs if FastSurfer fails#742
Merged
m-reuter merged 2 commits intoNov 8, 2025
Conversation
… so we can download and inspect the output on fails. Always print the parallel-processed hemi-wise logfiles to the console, so we have full logs in quicktest actions.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes two key improvements to the codebase: modifying log handling in the batch job runner and adding conditional guards to GitHub Actions workflow steps.
- Changes log appending from
cattoteein the batch job runner - Adds conditional execution guards to archive and upload steps in the GitHub Actions workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| recon_surf/functions.sh | Updates log aggregation to use tee instead of cat for appending logs |
| .github/actions/run-fastsurfer/action.yml | Adds if conditions to ensure archive and upload steps only run when docker loads successfully |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…loaded Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save quicktest processing artifacts output, even if fastsurfer fails, so we can download and inspect the output on fails.
Always print the parallel-processed hemi-wise logfiles to the console, so we have full logs in quicktest actions.