Remove corpus callosum processing from surface pipeline#787
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves corpus callosum (CC) processing out of the surface pipeline and makes the surface pipeline depend on segmentation outputs (specifically an aseg with CC inpainted). It also cleans up/filters some flags and updates user-facing documentation/help text accordingly.
Changes:
- Remove CC segmentation/inpainting execution from
recon-surf.shand instead requiremri/aseg.auto.mgzto exist. - Fix CC module execution flow in
run_fastsurfer.shso failures propagate correctly andcallosum_segupdates aren’t lost due to subshell scope. - Update CLI help/README and adjust flag filtering in
long_prepare_template.sh.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
run_fastsurfer.sh |
Help text updates + CC module control-flow fix to propagate exit codes and update callosum_seg in the main shell. |
recon_surf/recon-surf.sh |
Removes CC processing from surface pipeline and adds prerequisite check for aseg.auto.mgz. |
recon_surf/long_prepare_template.sh |
Filters/ignores additional flags to better interoperate with higher-level longitudinal wrappers. |
README.md |
Documentation updates to reflect correct flags and new surface prerequisites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6fe230c to
1a94d20
Compare
Make sure the corpus callosum_seg variable gets set in the main process not just the subshell. Add Corpus Callosum Paper Reference to run_fastsurfer.sh help text. Fix --norm_name help text in run_fastsurfer.sh Add asegdkt and corpus callosum dependency of surface pipeline in README.md Filter corpus callosum and other "unused" flags for long_prepare_template.sh
1a94d20 to
a50245c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes where the corpus callosum is run. It is no longer run in the surface pipeline, but now only checked. The surface pipeline terminates with error if
mri/aseg.auto.mgz, the aseg with CC inpainted, is missing.The PR also includes some flag filtering and cleanup and minor documentation fixes.
Remove corpus callosum processing from recon-surf.sh
Make sure the corpus callosum_seg variable gets set in the main process not just the subshell.
Add Corpus Callosum Paper Reference to run_fastsurfer.sh help text.
Fix --norm_name help text in run_fastsurfer.sh
Add asegdkt and corpus callosum dependency of surface pipeline in README.md
Filter corpus callosum and other "unused" flags for long_prepare_template.sh