Skip to content

Remove corpus callosum processing from surface pipeline#787

Merged
m-reuter merged 1 commit into
Deep-MI:devfrom
dkuegler:fix/remove-cc-recon-surf
Feb 13, 2026
Merged

Remove corpus callosum processing from surface pipeline#787
m-reuter merged 1 commit into
Deep-MI:devfrom
dkuegler:fix/remove-cc-recon-surf

Conversation

@dkuegler
Copy link
Copy Markdown
Member

@dkuegler dkuegler commented Feb 13, 2026

This PR changes where the corpus callosum is run. It is no longer run in the surface pipeline, but now only checked. The surface pipeline terminates with error if mri/aseg.auto.mgz, the aseg with CC inpainted, is missing.
The PR also includes some flag filtering and cleanup and minor documentation fixes.

Remove corpus callosum processing from recon-surf.sh
Make sure the corpus callosum_seg variable gets set in the main process not just the subshell.
Add Corpus Callosum Paper Reference to run_fastsurfer.sh help text.
Fix --norm_name help text in run_fastsurfer.sh
Add asegdkt and corpus callosum dependency of surface pipeline in README.md
Filter corpus callosum and other "unused" flags for long_prepare_template.sh

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves corpus callosum (CC) processing out of the surface pipeline and makes the surface pipeline depend on segmentation outputs (specifically an aseg with CC inpainted). It also cleans up/filters some flags and updates user-facing documentation/help text accordingly.

Changes:

  • Remove CC segmentation/inpainting execution from recon-surf.sh and instead require mri/aseg.auto.mgz to exist.
  • Fix CC module execution flow in run_fastsurfer.sh so failures propagate correctly and callosum_seg updates aren’t lost due to subshell scope.
  • Update CLI help/README and adjust flag filtering in long_prepare_template.sh.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
run_fastsurfer.sh Help text updates + CC module control-flow fix to propagate exit codes and update callosum_seg in the main shell.
recon_surf/recon-surf.sh Removes CC processing from surface pipeline and adds prerequisite check for aseg.auto.mgz.
recon_surf/long_prepare_template.sh Filters/ignores additional flags to better interoperate with higher-level longitudinal wrappers.
README.md Documentation updates to reflect correct flags and new surface prerequisites.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread recon_surf/recon-surf.sh Outdated
Comment thread recon_surf/long_prepare_template.sh Outdated
Comment thread run_fastsurfer.sh Outdated
Comment thread run_fastsurfer.sh Outdated
@dkuegler dkuegler force-pushed the fix/remove-cc-recon-surf branch 4 times, most recently from 6fe230c to 1a94d20 Compare February 13, 2026 17:40
Make sure the corpus callosum_seg variable gets set in the main process not just the subshell.
Add Corpus Callosum Paper Reference to run_fastsurfer.sh help text.
Fix --norm_name help text in run_fastsurfer.sh
Add asegdkt and corpus callosum dependency of surface pipeline in README.md
Filter corpus callosum and other "unused" flags for long_prepare_template.sh
@dkuegler dkuegler force-pushed the fix/remove-cc-recon-surf branch from 1a94d20 to a50245c Compare February 13, 2026 17:42
@m-reuter m-reuter merged commit 61e80d3 into Deep-MI:dev Feb 13, 2026
2 checks passed
@dkuegler dkuegler deleted the fix/remove-cc-recon-surf branch February 13, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants