Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two pipeline robustness issues: (1) preserving run_fastsurfer.sh invocation details in log files without being overwritten by version.py, and (2) preventing unintended cropping/shift during “soft” reorientation/keep-geometry workflows (notably affecting anisotropic/native-geometry segmentations).
Changes:
- Log the fully shell-escaped
run_fastsurfer.shinvocation into the segmentation log and append it to the build log generated byversion.py. - Fix/guard “soft” target-orientation reorientation to fall back to a discrete flip/reorder (no interpolation) when appropriate, plus add regression tests for non-cubic and keepgeom-like cases.
- Add
--keepgeom/--native_imagesupport topaint_cc_into_pred.pyand route CC post-processing through a temporary LIA space when needed.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
test/image/test_orientation_transform.py |
Adds regression tests ensuring soft reorientation roundtrips exactly without cropping for non-cubic/keepgeom-like inputs. |
run_fastsurfer.sh |
Records a properly quoted invocation string in logs; passes --keepgeom through to CC inpainting when native geometry is requested. |
FastSurferCNN/version.py |
Small refactor in read_and_close_version type handling (currently introduces a runtime issue). |
FastSurferCNN/data_loader/conform.py |
Improves soft reorientation path to prefer discrete transforms when no interpolation is required; minor formatting/type-check refactors (currently introduces runtime issues). |
CorpusCallosum/utils/visualization.py |
Refactors isinstance check (currently introduces a runtime issue). |
CorpusCallosum/shape/mesh.py |
Refactors isinstance check (currently introduces a runtime issue). |
CorpusCallosum/registration/midsagittal_plane_alignment.py |
Minor refactor (list-comp to generator unpacking). |
CorpusCallosum/paint_cc_into_pred.py |
Adds --keepgeom CLI flag; allows non-LIA inputs in keepgeom mode and performs correction in temporary LIA orientation with mapping back. |
CorpusCallosum/fastsurfer_cc.py |
Minor refactor (list-comp to generator unpacking). |
CorpusCallosum/data/read_write.py |
Refactors isinstance check (currently introduces a runtime issue). |
.gitignore |
Ignores /checkpoints/**. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: