CC Visualization fix#829
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes NaN thickness values in corpus callosum thickness visualization by handling the zero-distance interpolation case explicitly (when an interpolated point coincides with an existing contour point).
Changes:
- Update
insert_point_with_thickness()to detect existing points (within a tolerance) and return the existing index instead of inserting a duplicate point. - Extend
insert_point_with_thickness()return (whenreturn_index=True) with aninserted: boolflag and adjust endpoint index bookkeeping accordingly. - Guard
fill_thickness_values()against divide-by-zero by directly using the thickness value(s) of zero-distance neighbor(s).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
CorpusCallosum/shape/thickness.py |
Avoids duplicate-point insertion and propagates an inserted flag to prevent incorrect endpoint index shifts. |
CorpusCallosum/shape/contour.py |
Prevents NaNs during thickness interpolation when closest-distance is effectively zero. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed a small bug that would affect visualization of corpus callosum thickness estimates. Interpolation of thickness values could fail when the interpolated point and the original closest point would be equal, causing nan values in the results.
The fix is to take the value of the equal point directly, instead of weighting by distance.