Avoid uneven contour points error#830
Merged
Merged
Conversation
…d contour points match
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes FastSurfer-CC contour thickness handling so level-path endpoint insertions keep contour point counts consistent across slices, avoiding downstream mesh construction failures.
Changes:
- Updates
insert_point_with_thicknessto always insert a contour point, nudging matched existing vertices to avoid exact duplicates. - Removes the returned
insertedboolean and updates endpoint-index bookkeeping accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix in the CC pipeline skipped point interpolation when thickness endpoints matched with contour points. This lead to inconsisent numbers of points causing a crash later on. This PR should resolve that.