Spec: Expand image toggle (#171)#172
Merged
Merged
Conversation
Specify a per-instance toggle that expands a landscape gram's image to fill the GramFrame component width and consume available viewport height, with rendered size decoupled from natural size so coordinate transforms and persistent features stay locked to their data coordinates. Portrait verniers receive no toggle. Includes acceptance criteria and a demonstrator-based testing approach rebuilt from the published Pub-10 page. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017qyAAJ2oJo8uF5EaV3H3gd
Contributor
PR PreviewPreview deployment is ready! View Preview Last updated: 2026-06-25T13:42:39.420Z |
speckit.plan output for feature 156: plan.md, research.md, data-model.md, contracts/ (state shape + toggle UI), and quickstart.md. Constitution check passes (SVG-first, test-first, modular modes, declarative config all satisfied). Core approach: decouple rendered image size from natural size via renderWidth/renderHeight so coordinate transforms and persistent features stay locked to data coordinates; expand composes with the existing zoom transform. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017qyAAJ2oJo8uF5EaV3H3gd
speckit.tasks output: 32 dependency-ordered tasks across Setup, Foundational (render-size decoupling as a no-op refactor), and the three user stories (P1 expand/collapse MVP, P2 annotation lock, P3 portrait guard), plus polish. Tests included per the Test-First constitution principle and the spec's Playwright acceptance approach. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017qyAAJ2oJo8uF5EaV3H3gd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the feature specification for #171 — Add toggle for expand image at
specs/156-expand-image-toggle/spec.md. This is spec-only; no component code changes yet.The toggle lets an analyst expand a landscape gram's image to fill the GramFrame component width and consume most of the available viewport height, while the navigation, page title, and control panel stay visible. Portrait
verniersget no toggle.Key decisions captured
Acceptance testing
Documents a self-contained demonstrator rebuilt from the published Pub-10 page (
out/pub-10/Grams/gram1.html) — published shell/CSS/JS reused, published bundle swapped for the local build, landscapegram-1.png(902×237) — so Playwright can verify the 7 success criteria at a fixed viewport without running OxygenXML.Next steps (not in this PR)
sample/+ Playwright fixtureplan.md/tasks.md🤖 Generated with Claude Code
https://claude.ai/code/session_017qyAAJ2oJo8uF5EaV3H3gd
Generated by Claude Code