Skip to content

Fix edu challenge notebook and refactor config folder#390

Merged
YipengHu merged 15 commits intomainfrom
develop
Sep 1, 2020
Merged

Fix edu challenge notebook and refactor config folder#390
YipengHu merged 15 commits intomainfrom
develop

Conversation

@mathpluscode
Copy link
Copy Markdown
Member

@mathpluscode mathpluscode commented Aug 31, 2020

Description

  • remove config outside deepreg/
  • fix edu ch related to pyyaml and recent changes
  • add clarification on pypi

Fixes #386,#387

Type of change

What types of changes does your code introduce to DeepReg? Put an x in the boxes that
apply

  • Bugfix (non-breaking change which fixes an issue)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation Update (fix or improvement on the documentation)
  • New feature (non-breaking change which adds functionality)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help! This is
simply a reminder of what we are going to look for before merging your code.

  • I have
    installed pre-commit
    and formatted all changed files.
  • My commits' message styles matches
    our requested structure,
    e.g. Issue #<issue number>: detailed message.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@mathpluscode mathpluscode changed the title Develop Fix edu challenge notebook and refactor config folder Aug 31, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #390 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          29       29           
  Lines        1704     1704           
=======================================
  Hits         1681     1681           
  Misses         23       23           
Impacted Files Coverage Δ
deepreg/parser.py 100.00% <ø> (ø)
deepreg/predict.py 96.42% <100.00%> (ø)
deepreg/train.py 96.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab4ec4...1d14d58. Read the comment docs.

@YipengHu YipengHu merged commit 47370db into main Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move configs outside of deepreg

3 participants