Reload buffer only when secret length is not reached#17
Merged
shivam-deepsource merged 2 commits intomasterfrom Mar 2, 2022
Merged
Reload buffer only when secret length is not reached#17shivam-deepsource merged 2 commits intomasterfrom
shivam-deepsource merged 2 commits intomasterfrom
Conversation
souvik-deepsource
requested review from
shivam-deepsource and
yash-deepsource
as code owners
souvik-deepsource
changed the title
shivam-deepsource
approved these changes
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change improves the secret generation algorithm by not calling the buffer population method when the secret length is met.
Type of change
Please delete options that are not relevant.
Changes in this PR
populateBuffermethod, to be called when the random buffer loop exits prematurely without completing the secret lengthChecklist before merging
(Add to-do for reviewers and you to track, keep the PR in draft until all to-dos are cleared)
Note to reviewers (Optional)
(Anything that the reviewer should keep in mind)