Skip to content

Reload buffer only when secret length is not reached #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivam-deepsource merged 2 commits into from
Mar 2, 2022
Merged

Reload buffer only when secret length is not reached #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d86158a
Reload buffer when secret length is not reached
souvik-deepsource Feb 28, 2022
994e1d1
Format code with prettier
deepsource-autofix[bot] Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/shifty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,15 @@ export default class Shifty {
generate(length?: number): string {
length = length ? length : this.defaultLength;

this.populateBuffer();
let secret = "";

// The while loop ensures we always satisfy the length condition
// If the inner loop ends before we have the password of the required length
// the while loop will restart the inner loop
while (secret.length < length) {
// generate a new buffer everytime to ensure we don't end up with repeating values
this.populateBuffer();

for (
let rollIndex = 0;
rollIndex < this.randomBuffer.length;
Expand All @@ -103,10 +105,7 @@ export default class Shifty {
break;
}
}
// generate a new buffer to ensure we don't end up with repeating values
this.populateBuffer();
}

return secret;
}

Expand Down