Skip to content

Add check for device unplugged after detecting gst_error#415

Merged
brandonhs merged 1 commit intomainfrom
fix_gst_error_emit
Sep 30, 2024
Merged

Add check for device unplugged after detecting gst_error#415
brandonhs merged 1 commit intomainfrom
fix_gst_error_emit

Conversation

@brandonhs
Copy link
Copy Markdown
Member

@brandonhs brandonhs commented Sep 30, 2024

Description

Fix issue with gst_error getting emitted when device is unplugged. This led to the kernel issue being falsely detected when a device with a stream gets unplugged.

Type of change

Please select all that apply.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Other: [describe here]

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Make sure code runs/builds on Linux [REQUIRED]
    • Code produces no console errors upon launching the software
  • Other (add any other tests run)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added 1 or more reviewers to my pull request
    • Reviewer has run the above tests to verify
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Myself or a reviewer has tested my code to prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@brandonhs brandonhs self-assigned this Sep 30, 2024
Copy link
Copy Markdown
Member

@Tekunalogy Tekunalogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonhs brandonhs merged commit c55f2c3 into main Sep 30, 2024
@brandonhs brandonhs deleted the fix_gst_error_emit branch September 30, 2024 17:22
brandonhs added a commit that referenced this pull request Jan 16, 2026
Add check for device unplugged after detecting gst_error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants