Pin outbound connections to an already-checked address - #15835
Merged
Conversation
Hardening to the SSRF-safe HTTP session. The destination is resolved once and the socket is opened against an address that was already checked, rather than allowing a second lookup to supply a different one. Adds a regression test. No functional change for correctly-configured destinations.
blakeaowens
approved these changes
Sep 3, 2026
Maffooch
approved these changes
Sep 3, 2026
devGregA
approved these changes
Sep 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening / consistency improvement to outbound HTTP connection handling in the SSRF-safe session. The destination is now resolved once and the socket is opened against an address that was already checked, rather than allowing a second lookup to supply a different one. Adds a regression test.
No functional change for correctly-configured destinations.