[react-native-maps]: Remove myself from the definition owners#51300
[react-native-maps]: Remove myself from the definition owners#51300alloy merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
a-tarasyuk
commented
Feb 18, 2021
- Use a meaningful title for the pull request. Include the name of the package modified.
|
@a-tarasyuk Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 16 days — please try to get reviewers! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 51300,
"author": "a-tarasyuk",
"headCommitOid": "1ff34f284699a3329eaec7f116675ee62b348bb2",
"lastPushDate": "2021-02-16T19:21:09.000Z",
"lastActivityDate": "2021-02-28T01:38:45.000Z",
"maintainerBlessed": false,
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-native-maps",
"kind": "edit",
"files": [
{
"path": "types/react-native-maps/index.d.ts",
"kind": "definition"
}
],
"owners": [
"alloy",
"huhuanming",
"iRoachie",
"skn0tt",
"timwangdev",
"kamal",
"nelyousfi",
"alexdunne",
"swissmanu",
"bm-software",
"tkrotoff",
"a-tarasyuk",
"mvdam",
"esemesek",
"mrnickel",
"souvik-ghosh",
"nossbigg",
"saranshkataria",
"franzmoro",
"tykus160",
"methodbox"
],
"addedOwners": [],
"deletedOwners": [
"a-tarasyuk"
],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "tkrotoff",
"date": "2021-02-28T01:38:45.000Z",
"isMaintainer": false
}
],
"ciResult": "pass"
} |
|
🔔 @alloy @huhuanming @iRoachie @Skn0tt @timwangdev @kamal @nelyousfi @alexdunne @swissmanu @bm-software @tkrotoff @mvdam @Esemesek @mrnickel @souvik-ghosh @nossbigg @saranshkataria @franzmoro @tykus160 @methodbox — please review this PR in the next few days. Be sure to explicitly select |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. react-native-maps (unpkg)was missing the following properties:
|
|
Re-ping @alloy, @huhuanming, @iRoachie, @Skn0tt, @timwangdev, @kamal, @nelyousfi, @alexdunne, @swissmanu, @bm-software, @mvdam, @Esemesek, @mrnickel, @souvik-ghosh, @nossbigg, @saranshkataria, @franzmoro, @tykus160, @methodbox: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
I just published |