Skip to content

[react-native-maps]: Remove myself from the definition owners#51300

Merged
alloy merged 1 commit intoDefinitelyTyped:masterfrom
a-tarasyuk:feat/react-native-maps
Mar 5, 2021
Merged

[react-native-maps]: Remove myself from the definition owners#51300
alloy merged 1 commit intoDefinitelyTyped:masterfrom
a-tarasyuk:feat/react-native-maps

Conversation

@a-tarasyuk
Copy link
Copy Markdown
Contributor

  • Use a meaningful title for the pull request. Include the name of the package modified.

@a-tarasyuk a-tarasyuk requested a review from alloy as a code owner February 18, 2021 06:47
@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Feb 18, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 18, 2021

@a-tarasyuk Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 16 days — please try to get reviewers!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 51300,
  "author": "a-tarasyuk",
  "headCommitOid": "1ff34f284699a3329eaec7f116675ee62b348bb2",
  "lastPushDate": "2021-02-16T19:21:09.000Z",
  "lastActivityDate": "2021-02-28T01:38:45.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-native-maps",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-maps/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alloy",
        "huhuanming",
        "iRoachie",
        "skn0tt",
        "timwangdev",
        "kamal",
        "nelyousfi",
        "alexdunne",
        "swissmanu",
        "bm-software",
        "tkrotoff",
        "a-tarasyuk",
        "mvdam",
        "esemesek",
        "mrnickel",
        "souvik-ghosh",
        "nossbigg",
        "saranshkataria",
        "franzmoro",
        "tykus160",
        "methodbox"
      ],
      "addedOwners": [],
      "deletedOwners": [
        "a-tarasyuk"
      ],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "tkrotoff",
      "date": "2021-02-28T01:38:45.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @alloy @huhuanming @iRoachie @Skn0tt @timwangdev @kamal @nelyousfi @alexdunne @swissmanu @bm-software @tkrotoff @mvdam @Esemesek @mrnickel @souvik-ghosh @nossbigg @saranshkataria @franzmoro @tykus160 @methodbox — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Feb 18, 2021
@danger-public
Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react-native-maps (unpkg)

was missing the following properties:

  1. Animated
  2. ProviderPropType

Generated by 🚫 dangerJS against 1ff34f2

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Feb 28, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 28, 2021

Re-ping @alloy, @huhuanming, @iRoachie, @Skn0tt, @timwangdev, @kamal, @nelyousfi, @alexdunne, @swissmanu, @bm-software, @mvdam, @Esemesek, @mrnickel, @souvik-ghosh, @nossbigg, @saranshkataria, @franzmoro, @tykus160, @methodbox:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@alloy alloy merged commit f9152eb into DefinitelyTyped:master Mar 5, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

I just published @types/react-native-maps@0.24.1 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Edits Owners This PR adds or removes owners Owner Approved A listed owner of this package signed off on the pull request. Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants