Tedious - Adding setTimeout method to Request - v11.0.9#53970
Tedious - Adding setTimeout method to Request - v11.0.9#53970typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@zgarlett Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53970,
"author": "zgarlett",
"headCommitOid": "cece03fd0c7f01ef7aad2ff42b0ee22f7abafee5",
"lastPushDate": "2021-06-21T18:21:26.000Z",
"lastActivityDate": "2021-07-01T20:36:13.000Z",
"mergeOfferDate": "2021-07-01T15:46:21.000Z",
"mergeRequestDate": "2021-07-01T20:36:13.000Z",
"mergeRequestUser": "zgarlett",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "tedious",
"kind": "edit",
"files": [
{
"path": "types/tedious/index.d.ts",
"kind": "definition"
}
],
"owners": [
"rogierschouten",
"cjthompson",
"v-suhame",
"guiampm",
"csharpsi"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "orta",
"date": "2021-07-01T15:45:46.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 865248794,
"ciResult": "pass"
} |
|
Hey @zgarlett, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @rogierschouten @cjthompson @v-suhame @GuiAmPm @csharpsi — please review this PR in the next few days. Be sure to explicitly select |
|
I'm not sure how to write a test for this particular change. But it is simple and does bring it up to date with the library |
orta
left a comment
There was a problem hiding this comment.
Looks good to me, I checked it against the linked docs 👍🏻
|
@zgarlett Everything looks good here. Great job! I am ready to merge this PR (at cece03f) on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@rogierschouten, @cjthompson, @v-suhame, @GuiAmPm, @csharpsi: you can do this too.) |
|
Ready to merge |
|
I just published |
Please fill in this template.
npm test <package to test>.If changing an existing definition: