Skip to content

Tedious - Adding setTimeout method to Request - v11.0.9#53970

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
zgarlett:master
Jul 1, 2021
Merged

Tedious - Adding setTimeout method to Request - v11.0.9#53970
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
zgarlett:master

Conversation

@zgarlett
Copy link
Copy Markdown
Contributor

@zgarlett zgarlett commented Jun 21, 2021

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://tediousjs.github.io/tedious/api-request.html
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 21, 2021

@zgarlett Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53970,
  "author": "zgarlett",
  "headCommitOid": "cece03fd0c7f01ef7aad2ff42b0ee22f7abafee5",
  "lastPushDate": "2021-06-21T18:21:26.000Z",
  "lastActivityDate": "2021-07-01T20:36:13.000Z",
  "mergeOfferDate": "2021-07-01T15:46:21.000Z",
  "mergeRequestDate": "2021-07-01T20:36:13.000Z",
  "mergeRequestUser": "zgarlett",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "tedious",
      "kind": "edit",
      "files": [
        {
          "path": "types/tedious/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rogierschouten",
        "cjthompson",
        "v-suhame",
        "guiampm",
        "csharpsi"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "orta",
      "date": "2021-07-01T15:45:46.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 865248794,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Jun 21, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

Hey @zgarlett,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @rogierschouten @cjthompson @v-suhame @GuiAmPm @csharpsi — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@zgarlett
Copy link
Copy Markdown
Contributor Author

I'm not sure how to write a test for this particular change. But it is simple and does bring it up to date with the library

Copy link
Copy Markdown
Collaborator

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I checked it against the linked docs 👍🏻

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jul 1, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

@zgarlett Everything looks good here. Great job! I am ready to merge this PR (at cece03f) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@rogierschouten, @cjthompson, @v-suhame, @GuiAmPm, @csharpsi: you can do this too.)

@zgarlett
Copy link
Copy Markdown
Contributor Author

zgarlett commented Jul 1, 2021

Ready to merge

@typescript-bot typescript-bot merged commit 979ef48 into DefinitelyTyped:master Jul 1, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

I just published @types/tedious@4.0.4 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants