Upgrade wordpress/* type dependencies#54203
Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom Jul 1, 2021
Merged
Upgrade wordpress/* type dependencies#54203typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
Contributor
|
@sirreal Thank you for submitting this PR! This is a live comment which I will keep updated. 8 packages in this PR
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54203,
"author": "sirreal",
"headCommitOid": "3fc115b1018a7587314c74039ff5407eca30b735",
"lastPushDate": "2021-07-01T07:43:20.000Z",
"lastActivityDate": "2021-07-01T19:16:34.000Z",
"mergeOfferDate": "2021-07-01T16:50:41.000Z",
"mergeRequestDate": "2021-07-01T19:16:34.000Z",
"mergeRequestUser": "sirreal",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "wordpress__block-editor",
"kind": "edit",
"files": [
{
"path": "types/wordpress__block-editor/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__block-editor/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford",
"sirreal"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "wordpress__blocks",
"kind": "edit",
"files": [
{
"path": "types/wordpress__blocks/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__blocks/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford",
"sirreal"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "wordpress__components",
"kind": "edit",
"files": [
{
"path": "types/wordpress__components/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__components/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford",
"sirreal",
"p-jackson",
"saramarcondes"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "wordpress__compose",
"kind": "edit",
"files": [
{
"path": "types/wordpress__compose/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__compose/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "wordpress__edit-post",
"kind": "edit",
"files": [
{
"path": "types/wordpress__edit-post/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__edit-post/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "wordpress__editor",
"kind": "edit",
"files": [
{
"path": "types/wordpress__editor/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__editor/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "wordpress__media-utils",
"kind": "edit",
"files": [
{
"path": "types/wordpress__media-utils/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__media-utils/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "wordpress__plugins",
"kind": "edit",
"files": [
{
"path": "types/wordpress__plugins/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__plugins/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "orta",
"date": "2021-07-01T16:49:52.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "dsifford",
"date": "2021-07-01T13:18:56.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "sarayourfriend",
"date": "2021-07-01T12:49:39.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 872009408,
"ciResult": "pass"
} |
typescript-bot
added
Edits multiple packages
Untested Change
Contributor
|
Hey @sirreal, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
Contributor
|
🔔 @dsifford @p-jackson @saramarcondes — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Other Approved
5 tasks
dsifford
approved these changes
Jul 1, 2021
typescript-bot
added
the
Owner Approved
orta
approved these changes
Jul 1, 2021
Collaborator
orta
left a comment
orta
left a comment
There was a problem hiding this comment.
Mostly just version bump changes 👍🏻
typescript-bot
added
Maintainer Approved
Self Merge
Contributor
Contributor
Author
|
ready to merge |
Contributor
|
I just published |
Contributor
|
I just published |
Contributor
|
I just published |
Contributor
|
I just published |
Contributor
|
I just published |
Contributor
|
I just published |
Contributor
|
I just published |
Contributor
|
I just published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies for @wordpress/* types.
When using several @wordpress/* type packages, they'll pull in stale (non-type) dependencies duplicating dependencies of the actual @wordpress/* package.
This updates all affected packages to the major version aligning with current dependencies:
No other changes have been made.
npm test <package to test>.If changing an existing definition: