Skip to content

[@types/xrm] updated MS Docs links#63615

Merged
typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom
BetimBeja:fix/xrm/docs
Dec 24, 2022
Merged

[@types/xrm] updated MS Docs links#63615
typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom
BetimBeja:fix/xrm/docs

Conversation

@BetimBeja
Copy link
Copy Markdown
Contributor

@BetimBeja BetimBeja commented Dec 14, 2022

Please fill in this template.

Select one of these and delete the others:
If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: The change consisted in updating all the URLs to documentation considering the rebranding from MS Docs to MS Learn
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

Note: I only modified JS Docs so I can't add tests

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Dec 14, 2022

@BetimBeja Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63615,
  "author": "BetimBeja",
  "headCommitOid": "2c897dcf7382ca1280cebdf8430d050bc00e8758",
  "mergeBaseOid": "b30a172c1f24a9dea4d0c7821fff7e1884fcfe02",
  "lastPushDate": "2022-12-14T14:06:14.000Z",
  "lastActivityDate": "2022-12-24T14:56:15.000Z",
  "mergeOfferDate": "2022-12-24T14:03:31.000Z",
  "mergeRequestDate": "2022-12-24T14:56:15.000Z",
  "mergeRequestUser": "BetimBeja",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "xrm",
      "kind": "edit",
      "files": [
        {
          "path": "types/xrm/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xrm/xrm-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mattngan",
        "markusmauch",
        "daryllabar",
        "clownwilleatme",
        "scottdurow",
        "filcole",
        "power-maverick"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "filcole",
      "date": "2022-12-24T14:02:46.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "Power-Maverick",
      "date": "2022-12-14T12:49:08.000Z",
      "abbrOid": "b4015ee"
    }
  ],
  "mainBotCommentID": 1350845587,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Dec 14, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @mattngan @markusmauch @daryllabar @clownwilleatme @scottdurow @filcole @Power-Maverick — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Dec 14, 2022
@typescript-bot typescript-bot removed Owner Approved A listed owner of this package signed off on the pull request. Untested Change This PR does not touch tests labels Dec 14, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@Power-Maverick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@BetimBeja
Copy link
Copy Markdown
Contributor Author

@mattngan @markusmauch @daryllabar @clownwilleatme @scottdurow @filcole @Power-Maverick Merry Christmas 🤶
P.S. This PR can't be merged by me at the moment

Copy link
Copy Markdown
Contributor

@filcole filcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 24, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@BetimBeja: Everything looks good here. I am ready to merge this PR (at 2c897dc) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@mattngan, @markusmauch, @daryllabar, @clownwilleatme, @scottdurow, @filcole, @Power-Maverick: you can do this too.)

@BetimBeja
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit dda83a9 into DefinitelyTyped:master Dec 24, 2022
@BetimBeja BetimBeja deleted the fix/xrm/docs branch December 24, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants