[netmask]: Fix regressions in 2.0.0 typings

[Page-]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  • maskLong: https://github.com/rs/node-netmask/blob/2.0.2/lib/netmask.coffee#L97
  • netLong: https://github.com/rs/node-netmask/blob/2.0.2/lib/netmask.coffee#L114
  • Functions as methods: https://github.com/rs/node-netmask/blob/2.0.2/lib/netmask.coffee#L136
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@Page- Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• netmask — on npm, on unpkg
  • owner-approval: @JanST123

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 65824,
  "author": "Page-",
  "headCommitOid": "b382a5364cc1f5700133ff1a1a8bc688d4ca14c9",
  "mergeBaseOid": "94d68a3feab124a908cf95682dfcb254726ec0b5",
  "lastPushDate": "2023-06-19T15:17:46.000Z",
  "lastActivityDate": "2023-06-19T17:13:11.000Z",
  "mergeOfferDate": "2023-06-19T16:32:37.000Z",
  "mergeRequestDate": "2023-06-19T17:13:11.000Z",
  "mergeRequestUser": "Page-",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "netmask",
      "kind": "edit",
      "files": [
        {
          "path": "types/netmask/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/netmask/netmask-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mhfrantz",
        "JanST123"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "JanST123",
      "date": "2023-06-19T16:31:51.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1597108583,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @mhfrantz @JanST123 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[Page-]

These changes are notable if you are extending the netmask class, eg as in the case of https://github.com/balena-io/open-balena-vpn/blob/v11.26.5/src/utils/netmask.ts

[typescript-bot]

@JanST123 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[Page-]

I added a test

[typescript-bot]

@Page-: Everything looks good here. I am ready to merge this PR (at b382a53) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@mhfrantz, @JanST123: you can do this too.)

[Page-]

Ready to merge