Skip to content

Update CalendarApp.EventType to include EventType property#73018

Merged
typescript-bot merged 6 commits intoDefinitelyTyped:masterfrom
tdesrosi:master
Jun 13, 2025
Merged

Update CalendarApp.EventType to include EventType property#73018
typescript-bot merged 6 commits intoDefinitelyTyped:masterfrom
tdesrosi:master

Conversation

@tdesrosi
Copy link
Copy Markdown
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 13, 2025

@tdesrosi Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73018,
  "author": "tdesrosi",
  "headCommitOid": "6a9f6ecf46f48ef8d7fd47623ea2f62463b8ca49",
  "mergeBaseOid": "53bfedfd48a7c43300563aea6532597c859fc4c5",
  "lastPushDate": "2025-06-13T16:15:27.000Z",
  "lastActivityDate": "2025-06-13T17:03:37.000Z",
  "mergeOfferDate": "2025-06-13T16:56:11.000Z",
  "mergeRequestDate": "2025-06-13T17:03:37.000Z",
  "mergeRequestUser": "tdesrosi",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "google-apps-script",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-apps-script/google-apps-script.calendar.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/test/google-apps-script-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jpoehnelt",
        "sqrrrl",
        "PierrickVoulet",
        "vinay-google"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jpoehnelt",
      "date": "2025-06-13T16:55:33.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2970873042,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @jpoehnelt @sqrrrl @PierrickVoulet @vinay-google — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Jun 13, 2025
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 13, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Jun 13, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@tdesrosi: Everything looks good here. I am ready to merge this PR (at 6a9f6ec) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jpoehnelt, @sqrrrl, @PierrickVoulet, @vinay-google: you can do this too.)

@tdesrosi
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Jun 13, 2025
@typescript-bot typescript-bot merged commit 04643d1 into DefinitelyTyped:master Jun 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants