[fancytree] include missing type declarations from source#74972
Conversation
|
@daberni Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74972,
"author": "daberni",
"headCommitOid": "d6298f54ccae8983a211658bdba282be43c1c123",
"mergeBaseOid": "65acac0aa48fcb04a10eaa27f8f315b0c4b03076",
"lastPushDate": "2026-05-09T12:31:47.000Z",
"lastActivityDate": "2026-06-05T21:36:49.000Z",
"mergeOfferDate": "2026-06-05T20:33:54.000Z",
"mergeRequestDate": "2026-06-05T21:36:21.000Z",
"mergeRequestUser": "daberni",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "jquery.fancytree",
"kind": "edit",
"files": [
{
"path": "types/jquery.fancytree/index.d.ts",
"kind": "definition"
},
{
"path": "types/jquery.fancytree/jquery.fancytree-tests.ts",
"kind": "test"
},
{
"path": "types/jquery.fancytree/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"alphaleonis",
"itsmattius",
"niikoo",
"Nitecube",
"hosni"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "RyanCavanaugh",
"date": "2026-06-05T20:31:38.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 4412526560,
"ciResult": "pass"
} |
|
🔔 @alphaleonis @itsmattius @niikoo @Nitecube @hosni — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @alphaleonis, @itsmattius, @niikoo, @Nitecube, @hosni: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @daberni. (Ping @alphaleonis, @itsmattius, @niikoo, @Nitecube, @hosni.) |
RyanCavanaugh
left a comment
There was a problem hiding this comment.
Thanks for filling in these missing 2.38 APIs — most of the additions line up with the implementation source. I found one blocking regression: FancytreeOptions.source is now typed as only NodeData[] | NodeData, but the runtime also accepts Ajax options objects, functions, promises, and strings (dist/modules/jquery.fancytree.js documents object[]|object|string|$.Promise|function and has a source.url branch). Could you widen that type so valid usage like source: { url: "/api/tree" } continues to type-check?
|
@daberni One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@daberni The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
FancytreeOptions.source only accepted NodeData[] | NodeData, rejecting
the other input formats fancytree documents and handles in
nodeLoadChildren (object[] | object | string | $.Promise | function),
including Ajax options like source: { url: "/api/tree" }.
Introduce a SourceData union (inline data, URL string, $.ajax options
with a required url, jqXHR/promise) and accept it directly or via a
callback. Add tests covering each format. Also drop the redundant
generateFormElements overload that is subsumed by the wider one.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@daberni: Everything looks good here. I am ready to merge this PR (at d6298f5) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@alphaleonis, @itsmattius, @niikoo, @Nitecube, @hosni: you can do this too.) |
|
Ready to merge |
|
@typescript-bot Ready to merge |
pnpm test <package to test>.package.json.