Skip to content

[fancytree] include missing type declarations from source#74972

Merged
typescript-bot merged 3 commits into
DefinitelyTyped:masterfrom
daberni:fancytree
Jun 5, 2026
Merged

[fancytree] include missing type declarations from source#74972
typescript-bot merged 3 commits into
DefinitelyTyped:masterfrom
daberni:fancytree

Conversation

@daberni
Copy link
Copy Markdown
Contributor

@daberni daberni commented May 9, 2026

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test <package to test>.
  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/mar10/fancytree
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 9, 2026

@daberni Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74972,
  "author": "daberni",
  "headCommitOid": "d6298f54ccae8983a211658bdba282be43c1c123",
  "mergeBaseOid": "65acac0aa48fcb04a10eaa27f8f315b0c4b03076",
  "lastPushDate": "2026-05-09T12:31:47.000Z",
  "lastActivityDate": "2026-06-05T21:36:49.000Z",
  "mergeOfferDate": "2026-06-05T20:33:54.000Z",
  "mergeRequestDate": "2026-06-05T21:36:21.000Z",
  "mergeRequestUser": "daberni",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "jquery.fancytree",
      "kind": "edit",
      "files": [
        {
          "path": "types/jquery.fancytree/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jquery.fancytree/jquery.fancytree-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/jquery.fancytree/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "alphaleonis",
        "itsmattius",
        "niikoo",
        "Nitecube",
        "hosni"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2026-06-05T20:31:38.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 4412526560,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @alphaleonis @itsmattius @niikoo @Nitecube @hosni — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board May 9, 2026
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 20, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @alphaleonis, @itsmattius, @niikoo, @Nitecube, @hosni:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot
Copy link
Copy Markdown
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @daberni.

(Ping @alphaleonis, @itsmattius, @niikoo, @Nitecube, @hosni.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board May 27, 2026
Copy link
Copy Markdown
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filling in these missing 2.38 APIs — most of the additions line up with the implementation source. I found one blocking regression: FancytreeOptions.source is now typed as only NodeData[] | NodeData, but the runtime also accepts Ajax options objects, functions, promises, and strings (dist/modules/jquery.fancytree.js documents object[]|object|string|$.Promise|function and has a source.url branch). Could you widen that type so valid usage like source: { url: "/api/tree" } continues to type-check?

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jun 5, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@daberni One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Author Action in Pull Request Status Board Jun 5, 2026
@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed Revision needed This PR needs code changes before it can be merged. labels Jun 5, 2026
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Action in Pull Request Status Board Jun 5, 2026
@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jun 5, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@daberni The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Author Action in Pull Request Status Board Jun 5, 2026
@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed The CI failed When GH Actions fails labels Jun 5, 2026
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Action in Pull Request Status Board Jun 5, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

FancytreeOptions.source only accepted NodeData[] | NodeData, rejecting
the other input formats fancytree documents and handles in
nodeLoadChildren (object[] | object | string | $.Promise | function),
including Ajax options like source: { url: "/api/tree" }.

Introduce a SourceData union (inline data, URL string, $.ajax options
with a required url, jqXHR/promise) and accept it directly or via a
callback. Add tests covering each format. Also drop the redundant
generateFormElements overload that is subsumed by the wider one.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@typescript-bot typescript-bot removed the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Jun 5, 2026
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in Pull Request Status Board Jun 5, 2026
@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Jun 5, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@daberni: Everything looks good here. I am ready to merge this PR (at d6298f5) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alphaleonis, @itsmattius, @niikoo, @Nitecube, @hosni: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Jun 5, 2026
@daberni
Copy link
Copy Markdown
Contributor Author

daberni commented Jun 5, 2026

Ready to merge

@daberni
Copy link
Copy Markdown
Contributor Author

daberni commented Jun 5, 2026

@typescript-bot Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Jun 5, 2026
@typescript-bot typescript-bot merged commit bd15be7 into DefinitelyTyped:master Jun 5, 2026
4 checks passed
@daberni daberni deleted the fancytree branch June 5, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

3 participants