Skip to content

frida-gum: Add Interceptor instrumentation options#75060

Merged
typescript-bot merged 1 commit into
DefinitelyTyped:masterfrom
frida:frida-gum-instrumentation-options
May 30, 2026
Merged

frida-gum: Add Interceptor instrumentation options#75060
typescript-bot merged 1 commit into
DefinitelyTyped:masterfrom
frida:frida-gum-instrumentation-options

Conversation

@oleavr
Copy link
Copy Markdown
Contributor

@oleavr oleavr commented May 30, 2026

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test <package to test>.
  • Provide a URL to documentation or source code which provides context for the suggested changes: https://frida.re/news/
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 30, 2026

@oleavr Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75060,
  "author": "oleavr",
  "headCommitOid": "80bef13e099945c89bccb929580bd6be4568cf2f",
  "mergeBaseOid": "d64d9fa9ff732867115219ce27a93dada02c0f79",
  "lastPushDate": "2026-05-30T12:28:07.000Z",
  "lastActivityDate": "2026-05-30T12:47:06.000Z",
  "mergeOfferDate": "2026-05-30T12:34:01.000Z",
  "mergeRequestDate": "2026-05-30T12:47:06.000Z",
  "mergeRequestUser": "oleavr",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "frida-gum",
      "kind": "edit",
      "files": [
        {
          "path": "types/frida-gum/frida-gum-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/frida-gum/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/frida-gum/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "oleavr",
        "mrmacete",
        "hsorbo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "hsorbo",
      "date": "2026-05-30T12:30:32.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4582815582,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label May 30, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @mrmacete @hsorbo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board May 30, 2026
Copy link
Copy Markdown

@hsorbo hsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels May 30, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@oleavr: Everything looks good here. I am ready to merge this PR (at 80bef13) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@mrmacete, @hsorbo: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board May 30, 2026
@oleavr
Copy link
Copy Markdown
Contributor Author

oleavr commented May 30, 2026

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board May 30, 2026
@typescript-bot typescript-bot merged commit c612aba into DefinitelyTyped:master May 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

3 participants