Skip to content

[frida-gum] Add Memory.findPointers#75066

Merged
typescript-bot merged 1 commit into
DefinitelyTyped:masterfrom
frida:frida-gum-find-pointers
Jun 1, 2026
Merged

[frida-gum] Add Memory.findPointers#75066
typescript-bot merged 1 commit into
DefinitelyTyped:masterfrom
frida:frida-gum-find-pointers

Conversation

@oleavr
Copy link
Copy Markdown
Contributor

@oleavr oleavr commented Jun 1, 2026

Adds typings for Memory.findPointers(), a focused, SIMD-accelerated alternative to Memory.scan() for finding pointer-aligned words matching one or more values (e.g. references to a given address). Matches are collected and returned sorted by address.

function findPointers(
    ranges: MemoryRange | MemoryRange[],
    values: NativePointerValue[],
    mask?: NativePointerValue,
): MemoryPointerMatch[];

mask is applied to each scanned word and each value before comparing; it defaults to an exact match. Pass e.g. ptr("0x00007ffffffffff8") to strip arm64e PAC and non-pointer-isa bits.

This is owned by me (frida-gum maintainer).

@oleavr oleavr marked this pull request as draft June 1, 2026 18:39
@typescript-bot typescript-bot moved this to Needs Author Action in Pull Request Status Board Jun 1, 2026
@oleavr oleavr force-pushed the frida-gum-find-pointers branch from 802b8b2 to a44515a Compare June 1, 2026 18:43
@oleavr oleavr force-pushed the frida-gum-find-pointers branch from a44515a to 2fefb5d Compare June 1, 2026 20:06
@oleavr oleavr marked this pull request as ready for review June 1, 2026 20:06
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 1, 2026

@oleavr Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75066,
  "author": "oleavr",
  "headCommitOid": "2fefb5dd705a05b26398143043e3726bf7782ca8",
  "mergeBaseOid": "49ed2e3d3a1d88c397f0d40ea84f47f768823bf0",
  "lastPushDate": "2026-06-01T18:38:34.000Z",
  "lastActivityDate": "2026-06-01T20:48:55.000Z",
  "mergeOfferDate": "2026-06-01T20:13:11.000Z",
  "mergeRequestDate": "2026-06-01T20:48:55.000Z",
  "mergeRequestUser": "oleavr",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "frida-gum",
      "kind": "edit",
      "files": [
        {
          "path": "types/frida-gum/frida-gum-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/frida-gum/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/frida-gum/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "oleavr",
        "mrmacete",
        "hsorbo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "hsorbo",
      "date": "2026-06-01T20:10:47.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4596077527,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label Jun 1, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @mrmacete @hsorbo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Jun 1, 2026
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 1, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@oleavr: Everything looks good here. I am ready to merge this PR (at 2fefb5d) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@mrmacete, @hsorbo: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Jun 1, 2026
@oleavr
Copy link
Copy Markdown
Contributor Author

oleavr commented Jun 1, 2026

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Jun 1, 2026
@typescript-bot typescript-bot merged commit 95c9d09 into DefinitelyTyped:master Jun 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

3 participants