Add types for radio-browser - #75242
Conversation
- Fix CategoryItem.stationcount: string → number - Fix ClickStationResult.ok: string → boolean - Add ServerConfig interface, replace Record<string, unknown> return type - Add AddStationParams interface, replace Record<string, unknown> param type - Add CategoryType and FilterByType union types - Narrow getCategory category param to CategoryType - Narrow StationFilter.by to FilterByType - Use Partial<AddStationParams> for deprecated editStation params - Fix test import to CJS (import = require) - Add radio-browser devDependency for test module resolution - Expand test coverage: negative type tests, property access assertions
|
@CodeBeater Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75242,
"author": "CodeBeater",
"headCommitOid": "e0e4003ee65fcafd27fbc9cf1a027b9d57734539",
"mergeBaseOid": "f2c03b0708b64f141240f5c0b8589e9b6d02ef29",
"lastPushDate": "2026-07-10T05:55:11.000Z",
"lastActivityDate": "2026-08-02T05:24:46.000Z",
"mergeOfferDate": "2026-07-31T17:30:15.000Z",
"mergeRequestDate": "2026-08-02T05:24:46.000Z",
"mergeRequestUser": "CodeBeater",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "radio-browser",
"kind": "add",
"files": [
{
"path": "types/radio-browser/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/radio-browser/index.d.ts",
"kind": "definition"
},
{
"path": "types/radio-browser/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/radio-browser/radio-browser-tests.ts",
"kind": "test"
},
{
"path": "types/radio-browser/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"CodeBeater"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "RyanCavanaugh",
"date": "2026-07-31T17:29:35.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 4932431593,
"ciResult": "pass"
} |
|
🔔 @CodeBeater — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@CodeBeater The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
DT does not allow implementation packages in devDependencies unless they are on the allowed list. The types are self-contained and the test file resolves via the type definitions, not the actual package.
|
Re-ping @«anyone?»: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @CodeBeater. (Ping @«anyone?».) |
|
@CodeBeater: Everything looks good here. I am ready to merge this PR (at e0e4003) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
4c11bec
into
DefinitelyTyped:master
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.