webextension-polyfill: Update to latest type definitions from Firefox - #75460
Conversation
Major schema changes include: - New `contextualIdentities` APIs for remembering Firefox-native associations between websites and containers - The new `publicSuffix` API for identifying domains that are "public suffixes", or domains under which anyone can register their own subdomains (e.g. `com`, `co.uk`, etc.). - The new *documentId* property across various APIs, used to uniquely identify a document loaded in a tab or frame. - The new *splitViewId* property for identifying tabs that are part of a split view. - `userScript.execute()`, for injecting scripts into a specific tab. - Additional theming type definitions in `manifest`. ref: Lusito/webextension-polyfill-ts#119
|
@josh-berry Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75460,
"author": "josh-berry",
"headCommitOid": "bc8d355e1bd8e65b4616d010830b163dd89bd12b",
"mergeBaseOid": "1cafb92e1b267ac0c99ac7919e67011219efdbc4",
"lastPushDate": "2026-08-30T22:57:55.000Z",
"lastActivityDate": "2026-09-01T18:31:38.000Z",
"mergeOfferDate": "2026-09-01T18:30:23.000Z",
"mergeRequestDate": "2026-09-01T18:31:38.000Z",
"mergeRequestUser": "josh-berry",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "webextension-polyfill",
"kind": "edit",
"files": [
{
"path": "types/webextension-polyfill/index.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/contextualIdentities.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/events.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/geckoProfiler.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/manifest.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/proxy.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/publicSuffix.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/runtime.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/scripting.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/tabs.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/userScripts.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/webNavigation.d.ts",
"kind": "definition"
},
{
"path": "types/webextension-polyfill/namespaces/webRequest.d.ts",
"kind": "definition"
}
],
"owners": [
"Lusito",
"mnoorenberghe",
"josh-berry"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2026-09-01T18:29:41.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "mnoorenberghe",
"date": "2026-09-01T12:12:31.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 5471787700,
"ciResult": "pass"
} |
|
Hey @josh-berry, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @Lusito @mnoorenberghe — please review this PR in the next few days. Be sure to explicitly select |
|
Does this need a version bump at all? |
|
@jakebailey Are you asking about the minor version number? Historically we have only done that for breaking changes, which these are not (unless I've missed something). |
jakebailey
left a comment
There was a problem hiding this comment.
Yes, just checking, in case the version was tied to some upstream version.
|
@josh-berry: Everything looks good here. I am ready to merge this PR (at bc8d355) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Lusito, @mnoorenberghe: you can do this too.) |
|
Ready to merge |
5e9fcac
into
DefinitelyTyped:master
Major schema changes include:
contextualIdentitiesAPIs for remembering Firefox-native associations between websites and containerspublicSuffixAPI for identifying domains that are "public suffixes", or domains under which anyone can register their own subdomains (e.g.com,co.uk, etc.).userScript.execute(), for injecting scripts into a specific tab.manifest.Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.