Skip to content

webextension-polyfill: Update to latest type definitions from Firefox - #75460

Merged
typescript-automation[bot] merged 1 commit into
DefinitelyTyped:masterfrom
josh-berry:webextension-polyfill-ts/updates
Sep 1, 2026
Merged

webextension-polyfill: Update to latest type definitions from Firefox#75460
typescript-automation[bot] merged 1 commit into
DefinitelyTyped:masterfrom
josh-berry:webextension-polyfill-ts/updates

Conversation

@josh-berry

@josh-berry josh-berry commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Major schema changes include:

  • New contextualIdentities APIs for remembering Firefox-native associations between websites and containers
  • The new publicSuffix API for identifying domains that are "public suffixes", or domains under which anyone can register their own subdomains (e.g. com, co.uk, etc.).
  • The new documentId property across various APIs, used to uniquely identify a document loaded in a tab or frame.
  • The new splitViewId property for identifying tabs that are part of a split view.
  • userScript.execute(), for injecting scripts into a specific tab.
  • Additional theming type definitions in manifest.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
    • smoke-tested against josh-berry/tab-stash (only expected compile errors were seen)
  • Add or edit tests to reflect the change. - no test updates needed
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

Major schema changes include:

- New `contextualIdentities` APIs for remembering Firefox-native
  associations between websites and containers
- The new `publicSuffix` API for identifying domains that are "public
  suffixes", or domains under which anyone can register their own
  subdomains (e.g. `com`, `co.uk`, etc.).
- The new *documentId* property across various APIs, used to uniquely
  identify a document loaded in a tab or frame.
- The new *splitViewId* property for identifying tabs that are part of a
  split view.
- `userScript.execute()`, for injecting scripts into a specific tab.
- Additional theming type definitions in `manifest`.

ref: Lusito/webextension-polyfill-ts#119
@typescript-automation

typescript-automation Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

@josh-berry Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75460,
  "author": "josh-berry",
  "headCommitOid": "bc8d355e1bd8e65b4616d010830b163dd89bd12b",
  "mergeBaseOid": "1cafb92e1b267ac0c99ac7919e67011219efdbc4",
  "lastPushDate": "2026-08-30T22:57:55.000Z",
  "lastActivityDate": "2026-09-01T18:31:38.000Z",
  "mergeOfferDate": "2026-09-01T18:30:23.000Z",
  "mergeRequestDate": "2026-09-01T18:31:38.000Z",
  "mergeRequestUser": "josh-berry",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "webextension-polyfill",
      "kind": "edit",
      "files": [
        {
          "path": "types/webextension-polyfill/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/contextualIdentities.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/geckoProfiler.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/manifest.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/proxy.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/publicSuffix.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/scripting.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/tabs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/userScripts.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/webNavigation.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webextension-polyfill/namespaces/webRequest.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Lusito",
        "mnoorenberghe",
        "josh-berry"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2026-09-01T18:29:41.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "mnoorenberghe",
      "date": "2026-09-01T12:12:31.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 5471787700,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Aug 30, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

Hey @josh-berry,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @Lusito @mnoorenberghe — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-automation typescript-automation Bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Aug 30, 2026
@typescript-automation typescript-automation Bot added the Owner Approved A listed owner of this package signed off on the pull request. label Sep 1, 2026
@jakebailey

Copy link
Copy Markdown
Member

Does this need a version bump at all?

@josh-berry

Copy link
Copy Markdown
Contributor Author

@jakebailey Are you asking about the minor version number? Historically we have only done that for breaking changes, which these are not (unless I've missed something).

@jakebailey jakebailey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just checking, in case the version was tied to some upstream version.

@typescript-automation typescript-automation Bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 1, 2026
@typescript-automation typescript-automation Bot moved this from Needs Maintainer Review to Waiting for Author to Merge in Pull Request Status Board Sep 1, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

@josh-berry: Everything looks good here. I am ready to merge this PR (at bc8d355) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Lusito, @mnoorenberghe: you can do this too.)

@josh-berry

Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-automation typescript-automation Bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Sep 1, 2026
@typescript-automation
typescript-automation Bot merged commit 5e9fcac into DefinitelyTyped:master Sep 1, 2026
4 checks passed
@josh-berry
josh-berry deleted the webextension-polyfill-ts/updates branch September 1, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

3 participants