Skip to content

feat(ink-divider): remove types - #75491

Merged
typescript-automation[bot] merged 1 commit into
DefinitelyTyped:masterfrom
hkleungai:ink-divider-removal
Sep 3, 2026
Merged

feat(ink-divider): remove types#75491
typescript-automation[bot] merged 1 commit into
DefinitelyTyped:masterfrom
hkleungai:ink-divider-removal

Conversation

@hkleungai

Copy link
Copy Markdown
Contributor

See https://app.unpkg.com/ink-divider@2.3.2, JureSotosek/ink-divider@95f95f4.


Please fill in this template.

Select one of these and delete the others:

If removing a declaration:

  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-automation

typescript-automation Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@hkleungai Thank you for submitting this PR!

This is a live comment that I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes that affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75491,
  "author": "hkleungai",
  "headCommitOid": "bc0179ad8299b8d18552d2c6c38ef4d19e3eff40",
  "mergeBaseOid": "8443606b19593c505271bda9ad1238e10a2ef78a",
  "lastPushDate": "2026-09-03T10:40:49.000Z",
  "lastActivityDate": "2026-09-03T17:46:28.000Z",
  "mergeOfferDate": "2026-09-03T16:37:32.000Z",
  "mergeRequestDate": "2026-09-03T17:46:28.000Z",
  "mergeRequestUser": "hkleungai",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    },
    {
      "name": "ink-divider",
      "version": "2.0",
      "kind": "delete",
      "files": [
        {
          "path": "types/ink-divider/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/ink-divider/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ink-divider/ink-divider-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/ink-divider/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/ink-divider/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "omjadas"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2026-09-03T16:36:51.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 5524466038,
  "ciResult": "pass"
}

@typescript-automation

Copy link
Copy Markdown
Contributor

🔔 @omjadas — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-automation typescript-automation Bot moved this to Waiting for Code Reviews in Pull Request Status Board Sep 3, 2026
@typescript-automation typescript-automation Bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Sep 3, 2026
@typescript-automation typescript-automation Bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 3, 2026
@typescript-automation typescript-automation Bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Sep 3, 2026
@typescript-automation

Copy link
Copy Markdown
Contributor

@hkleungai: Everything looks good here. I am ready to merge this PR (at bc0179a) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@omjadas: you can do this too.)

@hkleungai

Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-automation typescript-automation Bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Sep 3, 2026
@typescript-automation
typescript-automation Bot merged commit 9b0ba5f into DefinitelyTyped:master Sep 3, 2026
4 checks passed
@hkleungai
hkleungai deleted the ink-divider-removal branch September 3, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Infrastructure Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

2 participants