Issue 1882 - Fix rolling out of character limit update - #1887
Merged
Conversation
JoerivanEngelen
approved these changes
Jul 27, 2026
Contributor
There was a problem hiding this comment.
Looks good, could you update the changelog? That we increased the max amount of characters to 40? I see there is a specific comment under fixed for imod5 with wells specific, but the change we make here is more general, as it applies to all keys assigned to a Modflow6 model.
Approving in advance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1882
Description
We now only raise an error if a key is longer than 40 characters and updated the relevant tests that were still looking for 16. After checking, we already truncate the names after the numbers are added (so the logic was already correct).
Checklist
Issue #nr, e.g.Issue #737pixi run generate-sbomand committed changes