feat(frontend): add "What's new" to the sidebar, ship the release video - #979
Merged
Conversation
Point the release video at the real dembrane recording and give people a way back to it. The automatic showing is unchanged: once per release, recorded as release_video_seen on app_user.settings, then never again on its own. - Add "What's new" to the Help block, above Documentation. It ignores the seen gate, so the video stays reachable after it has been dismissed. - Move ReleaseVideoModal from BaseLayout into HelpBlock, where the button that reopens it holds the open state via useDisclosure. HelpBlock renders for every signed-in user and survives a collapsed sidebar, so the automatic showing is unaffected. - Fix the modal arriving with no visible scrim. Mantine applies a `style` prop on Modal.Content to the full-viewport .inner wrapper as well as to the panel, so the background painted over the overlay. Use `styles`, which is keyed by selector. Drop the backdrop blur so the overlay matches every other modal. - Turn ENABLE_RELEASE_VIDEO_MODAL on in production. - Fill the last two untranslated Dutch strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point the release video at the real dembrane recording and give people a way back to it. The automatic showing is unchanged: once per release, recorded as release_video_seen on app_user.settings, then never again on its own.
styleprop on Modal.Content to the full-viewport .inner wrapper as well as to the panel, so the background painted over the overlay. Usestyles, which is keyed by selector. Drop the backdrop blur so the overlay matches every other modal.