docs(pptx): say what a partial capability actually costs#445
Merged
Conversation
The module README carried the same overstatement the release notes did: it described all ten partial capabilities as rendering "natively with an approximated styling detail". Reading the matrix rows rather than the count shows only some are that. The others lose content the format cannot carry — bookmarks after the first on a slide are dropped, parts of an inline SVG fall back to a transparent PNG, and the metadata producer value has no OPC field. The opening sentence also lumped "links and navigation" together as native. Links are: hyperlinks and internal slide jumps render as real PowerPoint links. Bookmarks are the degraded half, so a reader with a bookmark-heavy document was told the wrong thing about the one part that loses data. Split the summary so the partial group is not characterised as one thing, list the three content-losing cases under limitations, and record the clip raster's resolution behaviour — it targets a 2048-pixel long edge clamped between native size and 4x, which the matrix has carried since the clamp landed but this page did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
render-pptx/README.mdis the page GitHub renders for the artifact, and it carried the same overstatement the release notes did until #444: all ten partial capabilities described as rendering "natively with an approximated styling detail". Reading the matrix rows rather than the count shows only some are that. The others lose content the format cannot carry.The opening sentence also lumped "links and navigation" together as native. Links are — hyperlinks and internal slide jumps render as real PowerPoint links. Bookmarks are the degraded half: PPTX has no outline tree, so the first bookmark on a page names its slide and the rest are dropped. A reader with a bookmark-heavy document was told the wrong thing about the one part that actually loses data.
What changed
Every other claim on the page re-verified
graph-compose/-core/-bundlebundle/pom.xmldepends on wrapper + templates + fonts + emoji onlyrender-pdfat compile scope<scope>elementSLIDE_16_9960 × 540,SLIDE_4_3720 × 540DocumentPageSize:35/43)renderToImagesthrowsPptxSemanticBackendfootnote2.0.0cut-release.ps1flips it,VersionConsistencyGuardTestguards itVerification
./mvnw -B -ntp clean verify— BUILD SUCCESS, 1522 tests, 0 failures.