fix(render): footnote back-anchor on citing table cells#43
Merged
Conversation
Cell paragraphs bypass ParagraphRenderer, so a footnote first cited in a table cell had a forward link but a dead back-link (the note's marker targeted a fnref-N anchor never emitted). buildRow now asks RenderState for the back-anchor and sets it on the cell paragraph; anchor(null) is a no-op. Headings remain forward-only by design (their single anchor slot carries the slug) — RenderState Javadoc updated. Regression test: a footnote cited only from a table cell yields 2 GoTo actions. Suite green (167).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #40 (auto-closed when its stacked base branch was deleted at #39's merge; rebased onto develop, CHANGELOG conflict resolved — Unreleased is now Build/Fixed/Changed/Added). Same change and rationale as #40: cell paragraphs bypass ParagraphRenderer, so a footnote first cited in a table cell had a dead back-link; the fnref-N anchor is now placed on the citing cell (regression test asserts 2 GoTo). Gate: 167 tests green locally.