HTTP: lower proxy CRLF rejection log level - #1
Open
louzt wants to merge 1 commit into
Open
Conversation
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a small follow-up to your
no-crlf-injectionbranch.It changes the runtime-expanded proxy header name/value rejection logs from
NGX_LOG_ALERTtoNGX_LOG_ERRin:ngx_http_proxy_module.cngx_http_proxy_v2_module.cThere are no control-flow changes.
Why
The rejected input here is user-triggered bad runtime expansion in a vulnerable configuration. That is useful operator-facing error logging, but it should not trip the
nginx-testsautomaticno alertscheck.This matches Vadim's review distinction: user-triggered invalid runtime values should be
error, while internal consistency failures can remainalert.Validation
Built this branch with
--with-debugand ran the proxy-only nginx-tests draft PR against it:Result:
Related test PR: nginx/nginx-tests#55
Related upstream discussion in nginx#590.