Harden AI delegation, setup teardown, and knowledge docs#5
Merged
Conversation
- add fail-closed AI-maintainer tokens, identity checks, and teardown cleanup - make AsciiDoc first-class and convert the complete human TDD guide - document token-saving trade-offs and narrow committer delegation
DenWin
marked this pull request as ready for review
July 18, 2026 15:08
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aadf62c1c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DenWin
enabled auto-merge
July 18, 2026 15:39
- verify the requested repository installation before minting App tokens - bind setup-removal pushes to the validated credential over HTTPS - keep the temporary CODEOWNERS rule valid and teardown-safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Provide durable, product-specific AI delegation and a sourced documentation graph while making one-time setup safe to complete without leaving broken references.
Scope
AGENTS.md; keep Claude and Codex model/delegation mechanics in their own entry points. Make mechanical commit delegation opt-in and document its token trade-offs.SKILL.mdfiles remain Markdown.Complete-Setup.ps1verify identity and remove explicitly marked setup-only references from permanent docs before deletingsetup/.MIGRATION.md, setup version/changelog, Semgrep guidance, and GitHub automation claims with the current mechanisms and primary sources.Risk & rollback
Moderate. The setup scripts now enforce stricter identity preconditions and transform marked permanent documentation during teardown; tests cover both failure ordering and exact cleanup. The new App token helper reads a local private key and emits only a short-lived, repository-scoped token to stdout. The TDD documentation extension change could affect external deep links, but all in-repo Markdown and AsciiDoc links were checked. Roll back by reverting this PR; generated repositories should not run
Complete-Setup.ps1until this PR is merged and their setup steps are complete.Evidence
pre-commit run --all-files— all hooks passed, including Gitleaks, AsciiDoc, PSScriptAnalyzer, and the Fast test lane..config/scripts/Invoke-TestLane.ps1 -Lane Fast— 88 tests passed, 0 failed.setup/references.git diff --check— passed.