NPC Trait Updates#2833
Open
MC-Samuel wants to merge 8 commits into
Open
Conversation
…of Citizens' Sit, Sleep, and Sneak traits
davight
reviewed
Jul 13, 2026
| Entity entity = npc.getEntity(); | ||
| if (entity instanceof Sittable) { | ||
| ((Sittable) entity).setSitting(true); | ||
| if (npc.getEntity() instanceof Sittable sittable) { |
Contributor
There was a problem hiding this comment.
since this instanceof check is already made one time maybe you could use that one / be merged ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated Denizen's
SittingTrait,SleepingTrait, andSneakingTraittraits for Citizens'SitTrait,SleepTrait, andSneaktraits.NPC will be updated to the new version when any of these traits are adjusted through mechanisms or the
/npccommand.Fixes a bug reported at https://discord.com/channels/315163488085475337/1508455250594631794.
Requires CitizensDev/Citizens2#3321 to be merged first.This has been merged, but the build using this method (b4215) or higher is needed for MC 1.21+.