Skip to content

v0.7.0

Choose a tag to compare

@Dennis5882 Dennis5882 released this 15 Jul 03:57
fix: address Phase 5b code-review findings

design_forces.py and checks.py were written by two independent
parallel background agents that couldn't see each other's work,
producing three field-for-field-identical TypedDict pairs. Verified
against the manual (WD-ANAL's and WC-ANAL's WALL_IDS/SELECTIONS
schemas are literally identical; BD-REPORT's and BC/CC/BRC-REPORT's
DETAIL_POSITIONS schemas are literally identical) and consolidated:

- design_forces.py's RcWallIdsSelector/RcWallDesignSelection (used by
  WD-*) are now also imported by checks.py (used by WC-*) instead of
  checks.py redeclaring them locally as WallIdsSelector/
  WallCheckSelection.
- design_forces.py's RcBeamDetailPositions, renamed
  RcReportDetailPositions to reflect that it's shared across BD-REPORT
  and BC/CC/BRC-REPORT, is now imported by checks.py instead of
  redeclaring a local RcDetailPositions.

(Note: this review pass was done by direct manual read of all 4 ch26
files rather than the usual parallel finder-agent /code-review, since
the Agent tool hit a session-limit outage mid-run.)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>