getLegacyGitAccessor(): Don't ignore errors

[edolstra]

Motivation

Fix a regression introduced in fbf176d that caused getLegacyGitAccessor() to ignore errors from Git. This could lead to empty Git exports in the Nix store.

Context

Summary by CodeRabbit

Bug Fixes

• Enhanced output clarity for git submodule operations. When fetching git repositories with submodules enabled, the system now executes all necessary git operations without producing unnecessary console output. This results in significantly cleaner build logs and makes it easier to identify actual issues or important information during the fetch process.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b5b43d65-8605-428b-999a-e16980b40381

📥 Commits

Reviewing files that changed from the base of the PR and between b5c0faf and 7a0aade.

📒 Files selected for processing (1)

• src/libfetchers/git.cc

---

📝 Walkthrough

Walkthrough

The change replaces multiple runProgram() calls with runProgram2() in the legacy submodule-fetch path of the Git input scheme, routing stdout from git operations (init, remote add, fetch, checkout) into a StringSink to prevent output pollution while maintaining identical command execution and sequencing.

Changes

Cohort / File(s)	Summary
Git Legacy Submodule Output Handling src/libfetchers/git.cc	Replaced runProgram() invocations with runProgram2() calls in the getLegacyGitAccessor method for submodule fetches, redirecting stdout to StringSink for git init, remote add, fetch, and checkout commands to prevent stdout pollution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A rabbit's tale of cleaner streams,
Where git commands flow in silent beams,
No more pollution clogs the way,
StringSinks catch what words would say,
Output hidden, workflows clean,
The neatest submodule fix you've seen!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change in the changeset—replacing runProgram() calls with runProgram2() to capture stdout, thereby preventing error suppression in the legacy Git accessor function.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch eelcodolstra/nix-377

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Deployed on https://69dffab54c4f6f090b899b2a--determinate-nix.netlify.app

[cole-h]

Is there an easy way to add a regression test for this?