upload-debug-info-to-sentry.py: Add missing dependencies

[edolstra]

Motivation

Context

Summary by CodeRabbit

• Chores
  • Enhanced the environment setup for debug symbol uploads to Sentry, ensuring all necessary system tools are available for proper execution.

[coderabbitai]

📝 Walkthrough

Walkthrough

The Nix shebang in upload-debug-info-to-sentry.py is updated to explicitly declare python3 and binutils packages in the nix shell invocation, ensuring these dependencies are available at runtime rather than relying on implicit availability.

Changes

Cohort / File(s)	Summary
Nix Shebang Configuration maintainers/upload-debug-info-to-sentry.py	Modified shebang to explicitly include python3 and binutils packages in the nix shell environment specification, replacing implicit dependency reliance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 With a whisker twitch and a careful nod,
Dependencies declared, explicit as sod,
No more guessing what nix will find,
Python and binutils, now clearly assigned,
The script hops along, both swift and sure! 🌟

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding missing dependencies (python3 and binutils) to the Nix shebang in the upload-debug-info-to-sentry.py script.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentry-upload-deps

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@maintainers/upload-debug-info-to-sentry.py`:
- Line 2: Shebang's nix shell declaration is missing the xz package used later;
update the shebang line at the top (the line starting with #!nix shell
--inputs-from . ...) to include nixpkgs#xz among the listed inputs so the xz
binary is available when the script runs (this ensures the call to xz around the
decompression step later in the script succeeds).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a20c43b0-1180-4f59-a0f6-64ec88a65881

📥 Commits

Reviewing files that changed from the base of the PR and between 7ab838d and 7756c25.

📒 Files selected for processing (1)

• maintainers/upload-debug-info-to-sentry.py

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

script="$(fd -a 'upload-debug-info-to-sentry.py' | head -n1)"
echo "Reviewing: $script"
head -n 3 "$script"

echo
echo "Checking command availability in the exact shebang environment:"
nix shell --inputs-from . nixpkgs#sentry-cli nixpkgs#python3 nixpkgs#binutils --command bash -lc '
for cmd in python3 sentry-cli readelf xz nix; do
  printf "%-10s -> " "$cmd"
  command -v "$cmd" || echo "MISSING"
done
'

Repository: DeterminateSystems/nix-src

Length of output: 387

---

🏁 Script executed:

#!/bin/bash
# Read the file to verify the shebang and xz usage
script="maintainers/upload-debug-info-to-sentry.py"

echo "=== First 5 lines (including shebang) ==="
head -n 5 "$script"

echo -e "\n=== Lines around 75 (where xz is allegedly invoked) ==="
sed -n '70,80p' "$script"

echo -e "\n=== All invocations of xz in the file ==="
rg -n 'xz' "$script"

echo -e "\n=== All subprocess/external command invocations ==="
rg -n "subprocess|popen|call|run|check_output|check_call" "$script" -A 2

Repository: DeterminateSystems/nix-src

Length of output: 2273

---

Add xz to the nix shell dependencies in the shebang

Line 75 invokes xz to decompress data, but the nix shell declaration at line 2 does not include xz as a dependency. This will cause the script to fail at runtime in a clean nix environment.

Proposed fix

-#!nix shell --inputs-from . nixpkgs#sentry-cli nixpkgs#python3 nixpkgs#binutils --command python3
+#!nix shell --inputs-from . nixpkgs#sentry-cli nixpkgs#python3 nixpkgs#binutils nixpkgs#xz --command python3

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	#!nix shell --inputs-from . nixpkgs#sentry-cli nixpkgs#python3 nixpkgs#binutils --command python3
	#!nix shell --inputs-from . nixpkgs#sentry-cli nixpkgs#python3 nixpkgs#binutils nixpkgs#xz --command python3

🧰 Tools

🪛 Ruff (0.15.10)

[warning] 2-2: Shebang should be at the beginning of the file

(EXE005)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@maintainers/upload-debug-info-to-sentry.py` at line 2, Shebang's nix shell
declaration is missing the xz package used later; update the shebang line at the
top (the line starting with #!nix shell --inputs-from . ...) to include
nixpkgs#xz among the listed inputs so the xz binary is available when the script
runs (this ensures the call to xz around the decompression step later in the
script succeeds).

[github-actions]

🚀 Deployed on https://69ea314b3aa3833c6f609789--determinate-nix.netlify.app