fix(installer): ignore archive ownership on extraction - #1530
Merged
Conversation
Signed-off-by: xz-dev <xiangzhedev@gmail.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents the Unix installer from preserving release-builder ownership when extracting verified tar archives.
The official v0.10.0 Linux portable archive records
codebase-memory-mcpasrunner/runner. When root extracts it with plaintar -xzf, GNU tar restores that foreign UID. Candidate staging then rejects the file because activation requires the source owner to matchgeteuid(), producing:Using
tar --no-same-ownerkeeps extracted files owned by the invoking user and satisfies the existing activation security check. A smoke contract prevents the extraction flag from regressing.Duplicate search found no issue or PR for this release-archive ownership root cause. Related but distinct reports: #1529 (Windows temporary-directory ACL) and #1483 (test fixtures under umask 002).
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
Verification:
bash -n install.shbash -n tests/test_smoke_fixture_contract.shbash tests/test_smoke_fixture_contract.shscripts/check-dco.sh HEAD^..HEADgit diff --check origin/main...HEAD--no-same-ownerproduced current EUID.runner/runner; plain root extraction produced UID 1001 while patched extraction produced UID 0.