Skip to content

[chore] create installation pages for react-native sdk#227

Merged
suthar26 merged 1 commit into
mainfrom
DVC-6941-installation-page-for-react-native-sdk
Apr 13, 2023
Merged

[chore] create installation pages for react-native sdk#227
suthar26 merged 1 commit into
mainfrom
DVC-6941-installation-page-for-react-native-sdk

Conversation

@suthar26

Copy link
Copy Markdown
Contributor

No description provided.

@suthar26
suthar26 requested a review from a team April 13, 2023 18:47
@vercel

vercel Bot commented Apr 13, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devcycle-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 8:01pm

@aurorawalker aurorawalker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread docs/sdk/client-side-sdks/react-native/react-native-install.md Outdated
Comment thread docs/sdk/client-side-sdks/react-native/react-native-usage.md Outdated
| user | [DVCUser](https://github.com/DevCycleHQ/js-sdks/blob/main/sdk/js/src/types.ts#L55) | DevCycle user object |
| options | [DVCOptions](https://github.com/DevCycleHQ/js-sdks/blob/main/sdk/js/src/types.ts#L44) | DevCycle options object |

### Initialization Options

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move the Provider Config and Initialization Options in the Getting Started section? I'm also trying to figure out where it goes for the React docs and we should be consistent
because the initialization steps seem to be in the Getting Started section so we should keep them together?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah was confused about this too, I think we can move it to getting-started as it is the next step after install

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool I'll put them into the Getting Started section as well then

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that all the pages are somewhat inconsistent already - I have a followup task to ask Andrew in marketing to do a bit of a review of these docs as well (just need to chat with him).
But ultimately, if you see an easy small improvement, do it, but don't obsess over it! We can ask marketing to do follow up work on making it pretty/reviewing the organization etc.

@taplytics-robot
taplytics-robot force-pushed the DVC-6941-installation-page-for-react-native-sdk branch from 6712cae to 015599c Compare April 13, 2023 20:00
@suthar26
suthar26 merged commit e85aa15 into main Apr 13, 2023
@suthar26
suthar26 deleted the DVC-6941-installation-page-for-react-native-sdk branch April 13, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants