Conversation
AppContext.BaseDirectory may not be available in all hosting environments. Introduce PathResolver to provide a consistent base directory resolution strategy by falling back to Directory.GetCurrentDirectory() when AppContext.BaseDirectory is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change introduces a
PathResolverutility to centralize base directory resolution.Previously, DotEnv.Core relied directly on
AppContext.BaseDirectorywhen searching for.envfiles. While this works in most .NET hosting scenarios, it does not behave reliably under SampSharp/open.mp hosting.The new implementation falls back to
Directory.GetCurrentDirectory()whenAppContext.BaseDirectoryis unavailable, providing a more resilient path resolution strategy.Motivation
While migrating a game mode to SampSharp.OpenMp.Entities,
.envfiles could not be located correctly becauseAppContext.BaseDirectorywas not available as expected.According to SampSharp maintainer Tim Potze:
As a result, libraries that assume
AppContext.BaseDirectoryis always available may fail in custom hosting environments.Changes
PathResolverutility class.Directory.GetCurrentDirectory().AppContext.BaseDirectorywithPathResolver.BaseDirectory.