-
Notifications
You must be signed in to change notification settings - Fork 661
fix(react-wrapper): fixed T1279646 #29268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-wrapper): fixed T1279646 #29268
Conversation
apps/react/examples/Examples.tsx
Outdated
| {/* <FormExample /> */} | ||
|
|
||
| <ListExample /> | ||
| {/*<ListExample />*/} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we return this example? Or is there a reason it is still commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, reverted
apps/react/runner.js
Outdated
| return runner | ||
| .src('test.js') | ||
| .browsers('chrome:headless --disable-gpu --window-size=1200,800') | ||
| .src(path.join(__dirname, './__test__/*.ts')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these changes to the runner since we are not adding new tests in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
Co-authored-by: sergey-kras <krasnoluckiy280799@icloud.com>
Co-authored-by: sergey-kras <krasnoluckiy280799@icloud.com>
No description provided.