CardView: Implement Selection#29325
Merged
Alyar666 merged 8 commits intoDevExpress:grids/cardview/draftfrom Mar 28, 2025
Merged
CardView: Implement Selection#29325Alyar666 merged 8 commits intoDevExpress:grids/cardview/draftfrom
Alyar666 merged 8 commits intoDevExpress:grids/cardview/draftfrom
Conversation
Alyar666
force-pushed
the
cardview_selection_25_1
branch
from
fcd3c72 to
bf6ccd1
Compare
pomahtri
approved these changes
Mar 27, 2025
| /* eslint-disable @typescript-eslint/prefer-nullish-coalescing */ | ||
|
|
||
| import { isCommandKeyPressed } from '@js/common/core/events/utils/index'; | ||
| import { off, on } from '@js/events'; |
Contributor
There was a problem hiding this comment.
please add '/index', otherwise qunit will fail
|
|
||
| toolbar?: CardHeaderItem[]; | ||
|
|
||
| width?: number; |
Contributor
There was a problem hiding this comment.
looks like mistake after merge conflict solving. Do we need it?
| @@ -0,0 +1,17 @@ | |||
| export enum SelectionMode { | |||
Contributor
There was a problem hiding this comment.
better not to use enums, only type unions
export type SelectionMode = 'single' | 'none' etc
And better to import existing type from .d.ts
| const isSelectAll = this.isSelectAll(); | ||
| const isOnePageSelectAll = this.isOnePageSelectAll(); | ||
|
|
||
| this.toolbarController.addDefaultItem({ |
Contributor
There was a problem hiding this comment.
let's use approach from @Tucchhaa's PR to hide items
added 8 commits
March 28, 2025 05:30
Alyar666
force-pushed
the
cardview_selection_25_1
branch
from
93ece83 to
c933a41
Compare
Alyar666
merged commit 5007d76
into
DevExpress:grids/cardview/draft
116 of 261 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.