HTMLEditor: Handle integration errors #29741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-farkhutdinov
force-pushed
the
25_1_html_editor_ai_warnings
branch
from
eb2e2f7 to
c134dc3
Compare
r-farkhutdinov
force-pushed
the
25_1_html_editor_ai_warnings
branch
2 times, most recently
from
8deca4b to
f733325
Compare
marker-dao
reviewed
May 5, 2025
ksercs
reviewed
May 5, 2025
.../testing/tests/DevExpress.ui.widgets.htmlEditor/htmlEditorParts/aiDialogIntegration.tests.js
Outdated
Show resolved
Hide resolved
ksercs
reviewed
May 5, 2025
.../testing/tests/DevExpress.ui.widgets.htmlEditor/htmlEditorParts/aiDialogIntegration.tests.js
Outdated
Show resolved
Hide resolved
ksercs
reviewed
May 5, 2025
.../testing/tests/DevExpress.ui.widgets.htmlEditor/htmlEditorParts/aiDialogIntegration.tests.js
Outdated
Show resolved
Hide resolved
ksercs
reviewed
May 5, 2025
.../testing/tests/DevExpress.ui.widgets.htmlEditor/htmlEditorParts/aiDialogIntegration.tests.js
Outdated
Show resolved
Hide resolved
ksercs
reviewed
May 5, 2025
.../testing/tests/DevExpress.ui.widgets.htmlEditor/htmlEditorParts/aiDialogIntegration.tests.js
Outdated
Show resolved
Hide resolved
added 3 commits
May 6, 2025 10:17
r-farkhutdinov
force-pushed
the
25_1_html_editor_ai_warnings
branch
from
02cc3f9 to
bfeeea9
Compare
marker-dao
reviewed
May 6, 2025
| } | ||
| }; | ||
|
|
||
| export const hasInvalidCustomCommand = (commandsMap: CommandsMap): boolean => Object.keys(commandsMap).some((command) => command.startsWith('custom') && !commandsMap[command].prompt); |
Contributor
Author
There was a problem hiding this comment.
Agree, but I can't find a shorter name that will describe the function better. Also, I have seen longer function names in the codebase. If it's not critical, I would like to leave it as is.
Contributor
There was a problem hiding this comment.
Ruslan, you can just wrap body with {}
Contributor
Author
There was a problem hiding this comment.
Linter automatically fixes it to be in one line. We don't want to ignore this rule :)
Contributor
There was a problem hiding this comment.
you can extract commandNames variable, then it gotta be okay. But it's a minor so let's not waste time
ksercs
approved these changes
May 6, 2025
ajivanyandev
pushed a commit
that referenced
this pull request
May 23, 2025
Co-authored-by: Ruslan Farkhutdinov <ruslan.farkhutdinov@devexpress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.