Skip to content

Conversation

@pharret31
Copy link
Contributor

The PR to cover code review for an original PR (#29749)

  • The MessageBubble markup has been changed (its root component now can have a *-deleted class);
  • MessageBubble's _updateContent is only called when data fields are actually changed (test was added as well);
  • CSS markup was changed for the MessageBubble deleted element;
  • Other unit tests fixes.

…api-and-ui-for-removed-message' into 25_1_2804-chatediting-implement-api-and-ui-for-removed-message

# Conflicts:
#	packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebubble/_index.scss
#	packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebubble/_mixins.scss
#	packages/devextreme/js/__internal/ui/chat/messagebubble.ts
#	packages/devextreme/js/__internal/ui/chat/messagelist.ts
#	packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/chat.tests.js
…or-removed-message

# Conflicts:
#	packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebubble/_index.scss
#	packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebubble/_mixins.scss
#	packages/devextreme/js/__internal/ui/chat/messagebubble.ts
#	packages/devextreme/js/__internal/ui/chat/messagelist.ts
#	packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/chat.tests.js
#	packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/messageBubble.markup.tests.js
#	packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/messageBubble.tests.js
@pharret31 pharret31 added the 25_1 label May 3, 2025
@pharret31 pharret31 requested a review from EugeniyKiyashko May 3, 2025 11:40
@pharret31 pharret31 self-assigned this May 3, 2025
@pharret31 pharret31 marked this pull request as ready for review May 3, 2025 11:40
@EugeniyKiyashko EugeniyKiyashko self-requested a review May 5, 2025 07:39
@pharret31 pharret31 merged commit b0ac622 into DevExpress:25_1 May 5, 2025
300 checks passed
@pharret31 pharret31 deleted the 25_1_2804-chatediting-implement-api-and-ui-for-removed-message branch May 5, 2025 08:27
ajivanyandev pushed a commit that referenced this pull request May 23, 2025
…l changes) (#29766)

The PR to cover code review issues for an original PR (#29749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants