-
Notifications
You must be signed in to change notification settings - Fork 661
Scheduler: Refactor resource data accessor and grouping #29893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
41c109c to
78ad7d1
Compare
3b37719 to
fe2da5c
Compare
fe2da5c to
f893ad9
Compare
|
The OnContentReady behavior changed when we have a local resource Now it always work like remote Screen.Recording.2568-05-27.at.10.36.59.mov |
packages/devextreme/js/__internal/scheduler/utils/loader/resource_loader.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/appointments/data_provider/m_appointment_filter.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/appointments/data_provider/m_appointment_filter.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/appointments/m_settings_generator.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/utils/is_agenda_workpace_component.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/utils/data_accessor/appointment_data_accessor.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/utils/data_accessor/resource_data_accessor.ts
Show resolved
Hide resolved
Clicked wrong button while pushing comments, sorry :)
packages/devextreme/js/__internal/scheduler/utils/loader/loader.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/utils/loader/resource_loader.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/utils/loader/resource_loader.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/utils/resource_manager/agenda_group_utils.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/utils/resource_manager/resource_manager.ts
Outdated
Show resolved
Hide resolved
|
Unfortunately, found the broken case Configuration: const resourceA = {
fieldExpr: 'resourceId',
dataSource: [{
text: 'A',
id: 1,
color: '#1e90ff',
}],
};
const resourceB = {
fieldExpr: 'resourceId',
dataSource: [{
text: 'B',
id: 1,
color: '#f00',
}],
};
const appointment = {
startDate: '2024-01-01T01:00:00',
endDate: '2024-01-01T02:00:00',
text: 'Test appt',
resourceId: 1,
}
const scheduler = $('#scheduler').dxScheduler({
dataSource: [appointment],
views: [{
type: 'workWeek',
name: 'TestView',
}],
currentView: 'TestView',
currentDate: '2024-01-01',
groups: ['resourceId'],
resources: [resourceA],
}).dxScheduler('instance');
// Change resources synchronously
scheduler.option('resources', [resourceB]);In the previous `24.2``` version, this case works well (but with a remote DataSource, we will receive the internal error in both versions) I checked other similar cases (like similar runtime |
97ed529 to
21c8221
Compare
53e7d14 to
cb308f4
Compare
| @@ -0,0 +1,27 @@ | |||
| export const waitAsync = (timeout = 0, clock = undefined) => | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[🚨 Important]
Discussed and decided to get rid of this waitAsync in terms of a separate tech task
It's better to use the sinon.fakeTimers instead of the real marco tasks
No description provided.