CardView - editing - fixes #29898
CardView - editing - fixes #29898
Conversation
packages/devextreme/js/__internal/grids/new/grid_core/editing/public_methods.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
The design review point about editors' stylingMode isn't fixed
Let's set the stylingMode:'outline' for editors
There was a problem hiding this comment.
❌ Not fixed yet
How it looks (material):
How it should be (material):
There was a problem hiding this comment.
🚧 will be fixed in terms of a separate task -> w1ThR4Sp
There was a problem hiding this comment.
Issue with data type "date" + editing
Config:
dataSource: [
{
id: 0,
E: new Date('2024-01-01'),
}
],
keyExpr: 'id',
columns: [
{
dataField: 'E',
}
],
editing: {
mode: 'popup',
allowAdding: true,
allowUpdating: true,
allowDeleting: true,
},Steps:
- Edit existing card
- Clear the DateEditor value
Expected result
DateEditor without value, we can clear this field value
Actual result
DateEditor set 01/01/1970 value by default, we cannot clear the field value
There was a problem hiding this comment.
🚧 will be fixed as separate issue: id -> SiNOB53q
There was a problem hiding this comment.
New functionallity not covered by any type of tests (except some cases)
Let's cover at least happy pathes and discovered bugs cases
There was a problem hiding this comment.
🚧 Tests will be implemented in terms of separate task -> LJmmO1Gf
packages/devextreme/js/__internal/grids/new/grid_core/editing/popup/view.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/grid_core/editing/public_methods.ts
Show resolved
Hide resolved
| const originalContentReady = simpleFormItem?.editorOptions?.onContentReady; | ||
|
|
||
| simpleFormItem.editorOptions = { | ||
| stylingMode: 'outline', |
There was a problem hiding this comment.
Typo
| stylingMode: 'outline', | |
| stylingMode: 'outlined', |
There was a problem hiding this comment.
🚧 will be fixed as separate issue: id -> SiNOB53q
| return null; | ||
| } | ||
|
|
||
| const insertChange = changes.find( |
There was a problem hiding this comment.
[For future refactoring]
Let's rename this func, it's find an insert change, don't inserting anything :)
|
|
||
| private readonly visible = computed(() => !!this.editingController.editingCard.value); | ||
|
|
||
| private readonly customizeItems = computed(() => (item: dxForm.Item): void => { |
There was a problem hiding this comment.
Let's remove computed or leave a comment
Now it's not reactive
There was a problem hiding this comment.
🚧 will be fixed in terms of a separate card -> aG4dluUl
| )?.value ?? null, | ||
| onContentReady: (e): void => { | ||
| // TODO: refactor | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Let's clear this timeout in onDispose or sth like this
We cannot leave floating macro tasks by our code rules (in QUnit we have test for it for all components)
There was a problem hiding this comment.
🚧 will be fixed in terms of a separate task -> iL7V3E1H
There was a problem hiding this comment.
The delete confirmation dialog always showsa header (by default empty):
There was a problem hiding this comment.
🚧 will be fixed in terms of a separate task -> 1BvmPbSB
There was a problem hiding this comment.
Issue related to pagination
Config
dataSource: new Array(7).fill(null).map((_, idx) => ({
id: idx,
A: `A_${idx}`,
B: `B_${idx}`,
C: `C_${idx}`,
})),
keyExpr: 'id',
columns: ['A', 'B', 'C'],
editing: {
allowDeleting: true,
},Steps:
- Go to the second page
- Delete card (there is only one card on the 2nd page)
Expected result
Current page number changed to "1", and we see cards
Actual result
No data screen
There was a problem hiding this comment.
🚧 will be fixed in terms of separate task -> AYicExDv
2 participants
No description provided.