Skip to content

HTML editor: rework quill module integration types#30563

Merged
aleksei-semikozov merged 2 commits into
DevExpress:25_2from
aleksei-semikozov:html-editor-improove-types
Aug 1, 2025
Merged

HTML editor: rework quill module integration types#30563
aleksei-semikozov merged 2 commits into
DevExpress:25_2from
aleksei-semikozov:html-editor-improove-types

Conversation

@aleksei-semikozov
Copy link
Copy Markdown
Contributor

No description provided.

@aleksei-semikozov aleksei-semikozov self-assigned this Jul 31, 2025
@aleksei-semikozov aleksei-semikozov requested a review from a team as a code owner July 31, 2025 12:38
Comment thread packages/devextreme/js/__internal/ui/html_editor/html_editor.ts Outdated

export type Quill = QuillStatic;

export default Quill;
Copy link
Copy Markdown
Contributor

@ksercs ksercs Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it's better to implement these types directly in devextreme-quill repo + maybe reused existing external types like these ones. However, I agree it's more rational to do this work separately, so looks good enough for now

@aleksei-semikozov aleksei-semikozov force-pushed the html-editor-improove-types branch 2 times, most recently from 4529781 to dbfe7db Compare August 1, 2025 06:43
@aleksei-semikozov aleksei-semikozov force-pushed the html-editor-improove-types branch from dbfe7db to 5184bef Compare August 1, 2025 06:51
@aleksei-semikozov aleksei-semikozov merged commit 48bf553 into DevExpress:25_2 Aug 1, 2025
307 checks passed
@aleksei-semikozov aleksei-semikozov deleted the html-editor-improove-types branch March 20, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants