DataGrid - Tab key should activate editor with virtual scrolling enabled (T1290811) #30601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alyar666
requested changes
Aug 8, 2025
|
|
||
| const eventRowKeys = await ClientFunction(() => (window as any).eventRowKeys)(); | ||
|
|
||
| await t.expect(eventRowKeys).eql([49, 49, 49, 49, 49, 49]); |
Contributor
There was a problem hiding this comment.
Why was the allowUpdating callback called 6 times? The check is not obvious. If we don’t care about the number of times this callback is called, maybe it’s enough to check that there are no invalid values among the keys?
Or we could add only unique keys to the eventRowKeys array and check those.
|
|
||
| const eventRowKeys = await ClientFunction(() => (window as any).eventRowKeys)(); | ||
|
|
||
| await t.expect(eventRowKeys).eql([48, 48, 48, 48, 49, 49, 49]); |
Contributor
There was a problem hiding this comment.
The sameSame here. See the comment above.
Alyar666
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.