ColorBox: Update no-color image with colordismiss icon#30825
Merged
r-farkhutdinov merged 8 commits intoDevExpress:25_2from Sep 2, 2025
Merged
ColorBox: Update no-color image with colordismiss icon#30825r-farkhutdinov merged 8 commits intoDevExpress:25_2from
r-farkhutdinov merged 8 commits intoDevExpress:25_2from
Conversation
r-farkhutdinov
force-pushed
the
25_2_color_box_icon
branch
2 times, most recently
from
000cc67 to
f1b0be1
Compare
r-farkhutdinov
force-pushed
the
25_2_color_box_icon
branch
from
f1b0be1 to
a82be54
Compare
r-farkhutdinov
force-pushed
the
25_2_color_box_icon
branch
from
75325f4 to
4feff1d
Compare
pharret31
reviewed
Sep 1, 2025
Comment on lines
+301
to
+302
| this._$noColorIcon?.remove(); | ||
| this._$noColorIcon = undefined; |
Contributor
There was a problem hiding this comment.
Seems like this can be extracted to a separate function like cleanNoColorIcon or smth similar
r-farkhutdinov
force-pushed
the
25_2_color_box_icon
branch
from
3c1fc11 to
e999347
Compare
marker-dao
approved these changes
Sep 2, 2025
pharret31
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.