Skip to content

Form Smart Paste: Handle possible issues in smartPaste method#30957

Merged
juleari merged 11 commits intoDevExpress:25_2from
juleari:25_2_smartpaste_error_handling
Sep 2, 2025
Merged

Form Smart Paste: Handle possible issues in smartPaste method#30957
juleari merged 11 commits intoDevExpress:25_2from
juleari:25_2_smartpaste_error_handling

Conversation

@juleari
Copy link
Copy Markdown
Contributor

@juleari juleari commented Sep 1, 2025

No description provided.

@juleari juleari self-assigned this Sep 1, 2025
@juleari juleari requested a review from a team as a code owner September 1, 2025 11:12
@juleari juleari added the 25_2 label Sep 1, 2025
assert.deepEqual(smartPaste1.getCall(0).args, smartPaste1.getCall(0).args, 'new smartPaste invoked with same text and fields data');
});

QUnit.test('Default smartPaste button should be enabled if aiIntegration is set', function(assert) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these test can be combined with forEach, using editorType, value, expected format variables

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests you referring to don't use editorType or value
they are about default smart button

at the end of file there are dxCheckBox, dxSwitch, dxHtmlEditor and dxDateRangeBox tests.
dxCheckBox and dxSwitch are similar between each other (and differ from others because the resulted value is not string|[string]), but they also different from each other since one of them have default value of undefined, and other false.
dxHtmlEditor has html wrapper to its value. so it is also different from the others.

mistakes are similar though, but to me it does not look right to group mistakes, and not editors

@juleari juleari merged commit da3cede into DevExpress:25_2 Sep 2, 2025
399 of 400 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants