QUnit tests: get rid of material testing where possible #31459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pharret31
added
WIP
…cult-to-shift-to-a-fluent-theme
pharret31
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant theme-specific test files and consolidates testing by eliminating unnecessary duplication across Material and Generic themes. The changes focus on streamlining QUnit tests for Toolbar, Accordion, PivotGrid, and Form components.
Key changes:
- Removed shared test infrastructure files that were used to run identical tests across multiple themes
- Deleted theme-specific test entry points for generic_light and material_blue_light themes
- Created a single material-specific test file for Toolbar buttons and Form validation tests
- Added a new TestCafe test for Accordion icon-only button rendering
- Added import for FIELD_ITEM_CONTENT_WRAPPER_CLASS in form.tests.js
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/toolbarParts/toolbar.themes.sharedTests.js | Removed shared test infrastructure for toolbar theme testing |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/toolbar.materialTheme.tests.js | Removed material theme entry point (tests moved to toolbar.buttons.material.tests.js) |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/toolbar.genericTheme.tests.js | Removed generic theme test entry point |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/toolbar.buttons.material.tests.js | New consolidated test file for toolbar button rendering in material theme |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/accordionParts/accordion.themes.sharedTests.js | Removed shared test infrastructure for accordion theme testing |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/accordion.materialTheme.tests.js | Removed material theme test entry point |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/accordion.genericTheme.tests.js | Removed generic theme test entry point |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.themes.sharedTests.js | Removed shared test infrastructure for pivotGrid theme testing |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.materialTheme.tests.js | Removed material theme test entry point |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.genericTheme.tests.js | Removed generic theme test entry point |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.tests.js | Added import for FIELD_ITEM_CONTENT_WRAPPER_CLASS constant |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.materialTheme.tests.js | Removed most material theme tests, keeping only dx-invalid class validation tests |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.material.tests.js | New file with consolidated material theme form validation tests |
| e2e/testcafe-devextreme/tests/navigation/accordion/common.ts | Added TestCafe test for accordion with icon-only button rendering |
anna-shakhova
approved these changes
Oct 27, 2025
EugeniyKiyashko
approved these changes
Oct 27, 2025
sjbur
approved these changes
Oct 27, 2025
pharret31
deleted the
25_2_2596-qunit-tests-research-how-its-difficult-to-shift-to-a-fluent-theme
branch
pharret31
added a commit
to pharret31/DevExtreme
that referenced
this pull request
Oct 27, 2025
pharret31
added a commit
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.