Skip to content

Conversation

@r-farkhutdinov
Copy link
Contributor

No description provided.

@r-farkhutdinov r-farkhutdinov self-assigned this Nov 24, 2025
@r-farkhutdinov r-farkhutdinov marked this pull request as ready for review November 24, 2025 12:40
@r-farkhutdinov r-farkhutdinov requested review from a team as code owners November 24, 2025 12:40
Copilot AI review requested due to automatic review settings November 24, 2025 12:40
@r-farkhutdinov r-farkhutdinov marked this pull request as draft November 24, 2025 12:40
@r-farkhutdinov r-farkhutdinov marked this pull request as ready for review November 24, 2025 12:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a zIndex option to the Overlay widget and applies it to the LoadPanel in DataGrid/TreeGrid to fix z-index layering issues (T1308742). The implementation allows users to specify a custom z-index value instead of relying solely on the automatic z-index pool management.

Key Changes

  • Added zIndex option to Overlay widget allowing custom z-index values
  • Refactored z-index management logic to support both pool-based and custom z-index values
  • Set default z-index of 1000 for Grid LoadPanel to ensure proper layering

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
packages/devextreme/js/__internal/ui/overlay/overlay.ts Added zIndex property to OverlayProperties interface, implemented _handleZIndexOptionChanged method, refactored _updateZIndexStackPosition to support custom z-index, and added option change handler
packages/devextreme/js/__internal/grids/grid_core/m_utils.ts Added BASE_LOAD_PANEL_Z_INDEX constant (1000) and applied it to LoadPanel options in Grid
packages/devextreme/testing/tests/DevExpress.ui.widgets/overlay.tests.js Added three test cases covering custom zIndex initialization, changing from pool to custom zIndex, and resetting from custom to pool zIndex

@r-farkhutdinov r-farkhutdinov marked this pull request as draft November 24, 2025 13:19
@r-farkhutdinov r-farkhutdinov force-pushed the 25_2_T1308742_zindex_option branch from 413b8ee to 6d019a8 Compare November 24, 2025 13:36
@r-farkhutdinov r-farkhutdinov force-pushed the 25_2_T1308742_zindex_option branch from 6d019a8 to fa0b72e Compare November 24, 2025 13:51
@r-farkhutdinov r-farkhutdinov force-pushed the 25_2_T1308742_zindex_option branch from 357b171 to 9090f3c Compare November 24, 2025 14:06
@r-farkhutdinov r-farkhutdinov marked this pull request as ready for review November 24, 2025 14:09
Copilot AI review requested due to automatic review settings November 24, 2025 14:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/devextreme/js/__internal/ui/overlay/overlay.ts:1490

  • Similar to the issue in _updateZIndexStackPosition, custom zIndex values should not be removed from the pool during disposal. The check should verify that the zIndex is pool-managed: if (this._isVisible() && !this.option('zIndex')) { zIndexPool.remove(this._zIndex); }
    if (this._isVisible()) {
      zIndexPool.remove(this._zIndex);
    }

@r-farkhutdinov r-farkhutdinov merged commit 1008882 into DevExpress:25_2 Nov 25, 2025
93 checks passed
r-farkhutdinov added a commit to r-farkhutdinov/DevExtreme that referenced this pull request Nov 25, 2025
…42) (DevExpress#31815)

Co-authored-by: Ruslan Farkhutdinov <ruslan.farkhutdinov@devexpress.com>
r-farkhutdinov pushed a commit to r-farkhutdinov/DevExtreme that referenced this pull request Nov 25, 2025
…42) (DevExpress#31815)

Co-authored-by: Ruslan Farkhutdinov <ruslan.farkhutdinov@devexpress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants