DataGrid - AI Column: Endless prompt editor loading when edit prompt and rollback changes

[dmlvr]

No description provided.

[Copilot]

Pull request overview

This PR fixes an issue where the AI prompt editor would enter an endless loading state when a user edits a prompt and then rolls back the changes to the original value. The fix adds a check to prevent triggering the loading state and column option updates when the prompt value hasn't actually changed.

Key changes:

• Added early return in onSubmit handler when prompt value hasn't changed from the original
• Added comprehensive test coverage for the new behavior with two test cases
• Included temporary debug logging for troubleshooting

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
packages/devextreme/js/__internal/grids/grid_core/ai_column/views/m_ai_prompt_editor_view.ts	Added change detection logic in onSubmit to prevent unnecessary state updates and API calls when prompt hasn't changed; includes temporary debug console.log statements
packages/devextreme/js/__internal/grids/grid_core/ai_column/views/m_ai_prompt_editor_view.test.ts	Added two new test cases to verify that loading state is not triggered when prompt is unchanged and is properly triggered when prompt changes

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[Alyar666]

I think you can write it more simply:
this.updateButtonOption(APPLY_BUTTON_INDEX, 'disabled', !e.value || e.value === this.prompt);
this.updateButtonOption(REGENERATE_DATA_BUTTON_INDEX, 'disabled', !e.value || e.value !== this.prompt);

[Alyar666]

You can also move the e.value === this.prompt condition to a separate variable. For example, isValueChanged.

[dmlvr]

thank you! Did it

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.